Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run benchmark CI job if we have a base branch to compare to #76

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Only run benchmark CI job if we have a base branch to compare to #76

merged 1 commit into from
Jan 11, 2024

Conversation

simu
Copy link
Member

@simu simu commented Jan 10, 2024

Follow-up for #75

Checklist

  • The PR has a meaningful title. The title will be used to auto generate the changelog
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency, internal
    as they show up in the changelog
  • Link this PR to related PRs or issues.

@simu simu added the ignore label Jan 10, 2024
@simu simu requested a review from a team January 10, 2024 10:29
@github-actions GitHub Actions
Copy link

Benchmark for e975734

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1562.7±115.04µs 1575.9±134.93µs +0.84%
Reclass::inventory() single-threaded 3.4±0.02ms 3.5±0.13ms +2.94%

@simu simu merged commit 1383a1b into main Jan 11, 2024
18 checks passed
@simu simu deleted the fix/benchmark-ci branch January 11, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastjan bastjan bastjan approved these changes

Assignees
No one assigned
Labels
ignore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simu @bastjan