Add benchmarks for Reclass::render_inventory()
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
We add two standalone benchmarks for single-threaded and multi-threaded inventory rendering. The benchmarks are implemented with `criterion`. We need to have two separate benchmark binaries, since we're currently using the global `rayon` thread pool which can't be reinitialized.
simu
force-pushed
the
feat/bench-inventory
branch
5 times, most recently
from
86a8ee5 to
79b84a9
Compare
|
See #75 for an additional GitHub action job which runs the benchmarks for PRs and posts the result as a comment |
DebakelOrakel
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add two standalone benchmarks for single-threaded and multi-threaded inventory rendering. The benchmarks are implemented with
criterion.We need to have two separate benchmark binaries, since we're currently using the global
rayonthread pool which can't be reinitialized.Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog