Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove MarkdownEditor and MarkdownViewer #4782

Merged
merged 6 commits into from
Aug 16, 2024
Merged

refactor: remove MarkdownEditor and MarkdownViewer #4782

merged 6 commits into from
Aug 16, 2024

Conversation

joshblack
Copy link
Member

Closes https://github.com/github/primer/issues/3662
Closes https://github.com/github/primer/issues/3663

Changelog

New

Changed

Removed

  • Remove the MarkdownEditor component
  • Remove the MarkdownViewer component

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

This component has been upstreamed into GitHub UI and is no longer provided from Primer React.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9ab7e8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jul 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.27 KB (0%)
packages/react/dist/browser.umd.js 96.55 KB (0%)

@joshblack joshblack marked this pull request as ready for review August 12, 2024 15:43
@joshblack joshblack requested a review from a team as a code owner August 12, 2024 15:43
langermank
langermank approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@github-actions github-actions bot temporarily deployed to storybook-preview-4782 August 12, 2024 15:47 Inactive
@joshblack joshblack requested a review from a team as a code owner August 16, 2024 17:52
@joshblack joshblack requested a review from tbenning August 16, 2024 17:52
@github-actions github-actions bot temporarily deployed to storybook-preview-4782 August 16, 2024 18:22 Inactive
@joshblack joshblack enabled auto-merge August 16, 2024 19:12
@joshblack joshblack added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit a562465 Aug 16, 2024
30 checks passed
@joshblack joshblack deleted the refactor/remove-markdowneditor-markdownviewer branch August 16, 2024 19:27
@primer primer bot mentioned this pull request Aug 16, 2024
Merged
@siddharthkp siddharthkp restored the refactor/remove-markdowneditor-markdownviewer branch August 19, 2024 10:20
siddharthkp added a commit that referenced this pull request Aug 19, 2024
@siddharthkp
Revert "refactor: remove MarkdownEditor and MarkdownViewer (#4782)"
ba3e5e0 
This reverts commit a562465.
@siddharthkp siddharthkp mentioned this pull request Aug 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 19, 2024
@siddharthkp
Revert "refactor: remove MarkdownEditor and MarkdownViewer (#4782)" (#…
d4276ba 
…4860)

This reverts commit a562465.
siddharthkp added a commit that referenced this pull request Aug 21, 2024
@siddharthkp
Revert "Revert "refactor: remove MarkdownEditor and MarkdownViewer (#…
95a54b0 
…4782)" (…"

This reverts commit d4276ba.
@siddharthkp siddharthkp mentioned this pull request Aug 21, 2024
Closed
@siddharthkp siddharthkp deleted the refactor/remove-markdowneditor-markdownviewer branch October 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@tbenning tbenning Awaiting requested review from tbenning tbenning is a code owner automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @broccolinisoup @langermank