Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove MarkdownEditor and MarkdownViewer #4782

Merged
merged 6 commits into from
Aug 16, 2024
Merged

refactor: remove MarkdownEditor and MarkdownViewer #4782

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
840b9eb
refactor: remove MarkdownEditor and MarkdownViewer
joshblack Jul 26, 2024
e68079d
Merge branch 'main' of github.com:primer/react into refactor/remove-m…
joshblack Aug 12, 2024
be28025
chore: remove MarkdownEditor components from ActionBar
joshblack Aug 12, 2024
374a247
test(e2e): update e2e tests for ActionBar
joshblack Aug 16, 2024
ef22812
Merge branch 'main' of github.com:primer/react into refactor/remove-m…
joshblack Aug 16, 2024
9ab7e8f
test(vrt): update snapshots
joshblack Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor: remove MarkdownEditor and MarkdownViewer
  • Loading branch information
@joshblack
joshblack committed Jul 26, 2024
commit 840b9eb49d71ca739bc58efc84a6c5bca00faf5c
5 changes: 5 additions & 0 deletions .changeset/nasty-apricots-whisper.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

Remove the MarkdownEditor and MarkdownViewer components from Primer React
157 changes: 0 additions & 157 deletions docs/content/drafts/MarkdownEditor.mdx
View file
Open in desktop

This file was deleted.

103 changes: 0 additions & 103 deletions docs/content/drafts/MarkdownViewer.mdx
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions packages/react/src/__tests__/__snapshots__/exports.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,29 +267,18 @@ exports[`@primer/react/drafts should not update exports without a semver change
"type DataTableProps",
"default",
"default",
"default",
"Dialog",
"type DialogButtonProps",
"type DialogHeaderProps",
"type DialogHeight",
"type DialogProps",
"type DialogWidth",
"type Emoji",
"type FileType",
"type FileUploadResult",
"Hidden",
"type HiddenProps",
"InlineAutocomplete",
"type InlineAutocompleteProps",
"InlineMessage",
"type InlineMessageProps",
"type InteractiveMarkdownViewerProps",
"MarkdownEditor",
"type MarkdownEditorHandle",
"type MarkdownEditorProps",
"MarkdownViewer",
"type MarkdownViewerProps",
"type Mentionable",
"type NavigationProps",
"NavList",
"type NavListDividerProps",
Expand All @@ -302,8 +291,6 @@ exports[`@primer/react/drafts should not update exports without a semver change
"PageHeader",
"type PageHeaderProps",
"type ParentLinkProps",
"type Reference",
"type SavedReply",
"ScrollableRegion",
"type ScrollableRegionProps",
"SelectPanel",
Expand Down Expand Up @@ -381,31 +368,20 @@ exports[`@primer/react/experimental should not update exports without a semver c
"type DataTableProps",
"default",
"default",
"default",
"Dialog",
"type DialogButtonProps",
"type DialogHeaderProps",
"type DialogHeight",
"type DialogProps",
"type DialogWidth",
"type Emoji",
"FeatureFlags",
"type FeatureFlagsProps",
"type FileType",
"type FileUploadResult",
"Hidden",
"type HiddenProps",
"InlineAutocomplete",
"type InlineAutocompleteProps",
"InlineMessage",
"type InlineMessageProps",
"type InteractiveMarkdownViewerProps",
"MarkdownEditor",
"type MarkdownEditorHandle",
"type MarkdownEditorProps",
"MarkdownViewer",
"type MarkdownViewerProps",
"type Mentionable",
"type NavigationProps",
"NavList",
"type NavListDividerProps",
Expand All @@ -418,8 +394,6 @@ exports[`@primer/react/experimental should not update exports without a semver c
"PageHeader",
"type PageHeaderProps",
"type ParentLinkProps",
"type Reference",
"type SavedReply",
"ScrollableRegion",
"type ScrollableRegionProps",
"SelectPanel",
Expand Down
Loading
Loading