Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "refactor: remove MarkdownEditor and MarkdownViewer (#4782)" #4860

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Revert "refactor: remove MarkdownEditor and MarkdownViewer (#4782)" #4860

merged 1 commit into from
Aug 19, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Aug 19, 2024 •
edited
Loading

While these components have been upstreamed, the imports from primer/react still exist and can't be deleted without migrating them first

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2024

⚠️ No Changeset found

Latest commit: ba3e5e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp marked this pull request as ready for review August 19, 2024 10:21
@siddharthkp siddharthkp requested review from a team as code owners August 19, 2024 10:21
@github-actions github-actions bot added the staff Author is a staff member label Aug 19, 2024
@siddharthkp siddharthkp removed the request for review from emilybrick August 19, 2024 10:22
@siddharthkp siddharthkp mentioned this pull request Aug 19, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.3 KB (0%)
packages/react/dist/browser.umd.js 96.59 KB (0%)

@siddharthkp siddharthkp added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit d4276ba Aug 19, 2024
35 checks passed
@siddharthkp siddharthkp deleted the revert-4782-refactor/remove-markdowneditor-markdownviewer branch August 19, 2024 16:02
@siddharthkp siddharthkp mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

Assignees
No one assigned
Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddharthkp @langermank