Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scoring test scene for catch #24823

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Sep 15, 2023

1694777940

Of note, since catch doesn't really do "non-perfect" judgements, I added the a switch to turn off placing them in this change.

Testing resources

catch-scoring-resources.zip contains the following:

  • two .osu files that are catch beatmaps with 100 objects each
  • .osr files that correspond to replays set on the above beatmaps
  • .txt files containing extracts of stable total score after each judgement to cross-check.

Six different test cases are provided:

  • perfect score:
    • ScoreV1Perfect
    • ScoreV2Perfect
  • score with misses:
    • ScoreV1Misses
    • ScoreV2Misses

which correspond to the test steps added to the scene. For cross-referencing, set ScoreMultiplier = 3 in the test.

Stable code for reference:

@peppy
Copy link
Member

peppy commented Sep 18, 2023

Wondered where these ones were 😆

@peppy peppy merged commit aba98f2 into ppy:master Sep 19, 2023
@bdach bdach deleted the scoring-test-scene-catch branch September 19, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants