Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scoring test scene for taiko #24822

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Sep 15, 2023

1694777145

Testing resources

taiko-scoring-resources.zip contains the following:

  • TaikoTest.osu - a single taiko beatmap with 100 objects
  • .osr files that correspond to replays set on the above beatmap
  • .txt files containing extracts of stable total score after each judgement to cross-check.

Six different test cases are provided:

  • perfect score:
    • ScoreV1Perfect
    • ScoreV2Perfect
  • score with misses:
    • ScoreV1Misses
    • ScoreV2Misses
  • score with misses and OKs:
    • ScoreV1MissesAndOks
    • ScoreV2MissesAndOks

which correspond to the test steps added to the scene. For cross-referencing, set ScoreMultiplier = 3 in the test.

Of note, in the above test cases, it seems that the final total for ScoreV2Misses is off by one (1) point at the final judgement, despite being fully correct up to then. I decided not to bother investigating this further.

Stable code for reference:

@peppy peppy merged commit 18c18fe into ppy:master Sep 18, 2023
@bdach bdach deleted the scoring-test-scene-taiko branch September 18, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants