Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scoring test scene for mania #24824

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Sep 15, 2023

1694778527

Testing resources

mania-scoring-resources.zip contains the following:

  • ManiaTest.osu - a single mania beatmap with 100 objects
  • .osr files that correspond to replays set on the above beatmap
  • .txt files containing extracts of stable total score after each judgement to cross-check.

Six different test cases are provided:

  • perfect score:
    • PerfectScoreV1
    • PerfectScoreV2
  • score with misses:
    • ScoreV1Misses
    • ScoreV2Misses
  • score with misses and OKs:
    • ScoreV1MissesAndOks
    • ScoreV2MissesAndOks

which correspond to the test steps added to the scene. Contrary to the other rulesets, mania has no adjustable multiplier.

Stable code for reference:

@peppy peppy merged commit 1448477 into ppy:master Sep 19, 2023
@bdach bdach deleted the scoring-test-scene-mania branch September 19, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants