feat GH 45 add events for enabling and disabling autosave #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it compatible with the .editorconfig already present and didn't introduce any bells and whistles beyond that. Fixed the typo in .editorconfig indent_style while I was at it.
When this file is loaded, `cnf` has default options
Squashed changes from pocco81/auto-save.nvim#50 Got too hairy for a GH noob like me to fix properly.
Manually picked from pocco81/auto-save.nvim#67, namely 6203ae6.
Ancient news, doesn't affect this repo.
Also added acknowledgement to Pocco81's work on the original plugin.
Made stylua.toml use two spaces as indentation since that seems to be the most common convention in lua. Rest of the settings are kept in Stylua defaults but made explicit. Also updated .editorconfig to match config in stylua.toml.
Namely: applied stylua to the whole repo and ran marksman on README.md.
Closes #19.
Workflow was broken for everybody except me since pull_request trigger only works properly if every contributor has write access to the repo. With fork based workflow prevalent in Github the trigger to use is pull_request_target where the config and access token comes from main branch instead of the PR itself. Other notable changes: - Only run checks if lua files change - Run even if PR targets some branch other than main
vimdoc should update on every commit to `main`. This way the "Last change" info in vimdoc actually shows when the code was last changed even if the source file for help didn't change.
Other notable changes:
- Made README.md panvimdoc compatible
- Got rid of `<details>` and `<summary>` tags in installation instructions
- Made title, description and badges markdown only features (not included in vimdoc)
- Tweaked README.md appearance
- Raised all heading levels by one
- Updated description
- Added license badge
- Removed customisations from badges
- Left style as For the Badge though
- Added initial vimdoc, locally generated with panvimdoc
Closes #10.
Demojify used by panvimdoc to strip emojis is outdated, it doesn't include any codepoints since Unicode 12. So Hook emoji ended up in the vimdoc since it was included in Unicode 13. Switching to an older emoji is good enough a workaround for now. Also bumped panvimdoc version.
primeapple
deleted the
feat-GH-45-add-events-for-enabling-and-disabling-autosave
branch
primeapple
restored the
feat-GH-45-add-events-for-enabling-and-disabling-autosave
branch
primeapple
deleted the
feat-GH-45-add-events-for-enabling-and-disabling-autosave
branch
primeapple
restored the
feat-GH-45-add-events-for-enabling-and-disabling-autosave
branch
okuuva
deleted the
feat-GH-45-add-events-for-enabling-and-disabling-autosave
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debounce_delayoption not being readconditionbefore setting timers (Abort save in hook_before_saving()? #16)conditionswith hooks setup #20)execution_messageis not updated #21)execution_message#21 #22)vim-yoink#15] Implement config option fornoautocmd(TextChangedevent bug? #31)trigger_eventscrash the plugin (auto-save.nvim rewrite: everything changed #33)patterntotrigger_events(Fix to not try to save a deleted buffer #42)