-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add defer_save, cancel_save, immediate_save trigger options #11
feat: add defer_save, cancel_save, immediate_save trigger options #11
Conversation
e3e3800
to
8cf0bf0
Compare
Just from the codestructure I'm happy now. @okuuva feel free to have a look over it. I also added some |
Excellent work @primeapple! I'll take it into daily use as well to spot any potential problems but LGTM already :) |
And I do agree with the TODOs. I wouldn't maybe drop those in this MR just yet just to keep things as atomic as possible. And I need to comb through the code a few more times since I've also wondered what's the point with those seemingly unused things. Probably remnants from the rewrite Pocco81 did in July 2022 but need to triple check. |
I'll remove the todos and open another PR afterwards to add them, maybe even removing the potential unused code. Thanks for the review :) |
I have some trouble because it doesn't seem to be possible to set timers to buffer variables, see here: https://www.reddit.com/r/neovim/comments/123y048/cannot_convert_userdata_when_trying_to_set_a/ I might just use the |
Ok. I open this as "Ready for review". It works quite well on my machine now, you are save to try it out @okuuva :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had time to test this thoroughly since I was away for the weekend and been sick since I got back. But couldn't find any obvious problems with the short time I had to test it, the code looks good to me and I trust you've been testing it yourself during the development much more rigorously than I have. Exceptional job!
defer_save
, cancel_save
, immediate_save
trigger options
Ok, thank you! |
This fixes #8