Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dim would not get applied when lazy loading plugin #27

Merged

Conversation

primeapple
Copy link
Collaborator

Fixes #26

  • Dim is now getting applied when plugin is turned on, as well as when the colorscheme is changed
  • Only apply dim if execution message is enabled
  • Moved the color logic out of init.lua, into colors.lua
  • Added some types

Copy link
Owner

@okuuva okuuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about naming and an added TODO. Great work once again, thanks!

@primeapple primeapple force-pushed the feature/26-fix-dim-not-getting-loaded branch from 534a7dd to b30f6f4 Compare July 3, 2023 18:53
@primeapple primeapple requested a review from okuuva July 3, 2023 18:59
Copy link
Owner

@okuuva okuuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@primeapple
Copy link
Collaborator Author

I added comments to describe the legacy nature of this code.

You can merge now.

Btw, can you give me write access? I promise I won't merge anything without an approval, but it would be nice nethertheless ;-)

@okuuva
Copy link
Owner

okuuva commented Jul 5, 2023

Btw, can you give me write access? I promise I won't merge anything without an approval, but it would be nice nethertheless ;-)

I can and will :) I really appreciate your efforts on making auto-save.nvim better, thank you! I'll set it up shortly.

@okuuva
Copy link
Owner

okuuva commented Jul 5, 2023

I added comments to describe the legacy nature of this code.

You can merge now.

Thank you for the edits! You should be able to merge this now yourself :)

@primeapple primeapple merged commit cb3b5f5 into okuuva:main Jul 5, 2023
@primeapple primeapple deleted the feature/26-fix-dim-not-getting-loaded branch July 5, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The dim setting doesn't work when the plugin is lazy-loaded
2 participants