-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#7237: Drop unused webextAlert
#7384
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7384 +/- ##
==========================================
- Coverage 72.52% 72.46% -0.06%
==========================================
Files 1207 1205 -2
Lines 37684 37533 -151
Branches 7067 7051 -16
==========================================
- Hits 27331 27199 -132
+ Misses 10353 10334 -19 ☔ View full report in Codecov by Sentry. |
Marking @grahamlangford as primary reviewer. Apologies for accidentally closing - hit the wrong button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See package-lock
conflict
What does this PR do?
Discussion
sidePanel
, this will become dead code after thesidePanel
PR is mergedFuture Work
If background
alert
s ever become needed again, either revert this PR or use https://github.com/fregante/webext-alertChecklist