Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7237: Drop unused webextAlert #7384

Merged
merged 6 commits into from
Jan 22, 2024
Merged

#7237: Drop unused webextAlert #7384

merged 6 commits into from
Jan 22, 2024

Conversation

fregante
Copy link
Contributor

What does this PR do?

Discussion

  • This alert was only used by Firefox in MV2. I only left it in here because MV3 would have needed it for the sidebar injection
  • Since we're going to use the sidePanel, this will become dead code after the sidePanel PR is merged

Future Work

If background alerts ever become needed again, either revert this PR or use https://github.com/fregante/webext-alert

Checklist

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7a5e2e9) 72.52% compared to head (a8e87a9) 72.46%.
Report is 1 commits behind head on main.

❗ Current head a8e87a9 differs from pull request most recent head 155223e. Consider uploading reports for the commit 155223e to get more accurate results

Files Patch % Lines
src/background/browserAction.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7384      +/-   ##
==========================================
- Coverage   72.52%   72.46%   -0.06%     
==========================================
  Files        1207     1205       -2     
  Lines       37684    37533     -151     
  Branches     7067     7051      -16     
==========================================
- Hits        27331    27199     -132     
+ Misses      10353    10334      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twschiller
Copy link
Contributor

twschiller commented Jan 21, 2024

Marking @grahamlangford as primary reviewer. Apologies for accidentally closing - hit the wrong button

@twschiller twschiller closed this Jan 21, 2024
@twschiller twschiller reopened this Jan 21, 2024
Copy link
Collaborator

@grahamlangford grahamlangford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See package-lock conflict

@fregante fregante enabled auto-merge (squash) January 22, 2024 15:40
@fregante fregante merged commit 4fa33c6 into main Jan 22, 2024
12 of 13 checks passed
@fregante fregante deleted the F/ci/webext-alert branch January 22, 2024 15:41
@grahamlangford grahamlangford added this to the 1.8.8 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firefox Issues related to Firefox
Development

Successfully merging this pull request may close these issues.

3 participants