#7228: Add support for sidePanel in the MV3 build #7354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7354 +/- ##
==========================================
- Coverage 72.58% 72.52% -0.07%
==========================================
Files 1204 1211 +7
Lines 37650 37827 +177
Branches 7060 7101 +41
==========================================
+ Hits 27330 27433 +103
- Misses 10320 10394 +74 ☔ View full report in Codecov by Sentry. |
fregante
commented
Jan 18, 2024
| await rehydrateSidebar({ | ||
| tabId, | ||
| }); | ||
| updateSidebar(contentScriptTarget); |
There was a problem hiding this comment.
I need to double-check:
- Is
updateSidebarequivalent torehydrateSidebar - Is
updateSidebarequivalent to the optional part ofshowSidebar?
Comment on lines
39
to
49
| <div className="mt-2"> | ||
| Looking for the Extension Console?{" "} | ||
| <a | ||
| href="#" | ||
| onClick={async () => { | ||
| await browser.runtime.openOptionsPage(); | ||
| }} | ||
| > | ||
| Open the Extension Console | ||
| </a> | ||
| </div> |
There was a problem hiding this comment.
I believe this was removed by mistake?
There was a problem hiding this comment.
It was merged into the other component because it was 70% duplicate code and I had to further customize the on click handler
There was a problem hiding this comment.
Restored and verified:
grahamlangford
approved these changes
Jan 23, 2024
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
This was referenced Jan 25, 2024
1 task
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chrome.sidePanelPOC 3 #7320The MV3 sidePanel PR seems stable and working, so the setup seems to be correct.
In this PR I will restore MV2 support on top of the new sidePanel setup.
Next steps
Graham is preparing: https://www.notion.so/pixiebrix/MV3-Side-Panel-Regression-Tests-12495993574541afa987e6d3f9762b67
Plus:
What's not part of this PR