Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7420: Drop updateSidebar call from browserAction.onClick #7428

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Jan 25, 2024

What does this PR do?

Checklist

  • Add tests
  • New files added to src/tsconfig.strictNullChecks.json (if possible)
  • Designate a primary reviewer: @grahamlangford

Follows

@fregante fregante marked this pull request as ready for review January 25, 2024 09:37
@fregante fregante changed the title Drop updateSidebar call from browserAction Drop updateSidebar call from browserAction.onClick Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (808cbc8) 72.60% compared to head (297926c) 72.61%.

Files Patch % Lines
src/contentScript/sidebarDomControllerLite.ts 0.00% 3 Missing ⚠️
src/background/browserAction.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7428      +/-   ##
==========================================
+ Coverage   72.60%   72.61%   +0.01%     
==========================================
  Files        1212     1212              
  Lines       37846    37839       -7     
  Branches     7099     7100       +1     
==========================================
- Hits        27479    27478       -1     
+ Misses      10367    10361       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fregante fregante changed the title Drop updateSidebar call from browserAction.onClick #7420: Drop updateSidebar call from browserAction.onClick Jan 25, 2024
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@fregante fregante merged commit ed0e25b into main Jan 25, 2024
16 checks passed
@fregante fregante deleted the F/bug/sidebar-mv2-noise branch January 25, 2024 15:37
@grahamlangford grahamlangford added this to the 1.8.8 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants