Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7237: Drop unused webextAlert #7384

Merged
merged 6 commits into from
Jan 22, 2024
Merged

#7237: Drop unused webextAlert #7384

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
119f113
Drop `webextAlert`
fregante Jan 20, 2024
f652d61
Lint
fregante Jan 21, 2024
a8e87a9
Correct message
fregante Jan 21, 2024
2260cb4
Merge remote-tracking branch 'origin/main' into F/ci/webext-alert
fregante Jan 22, 2024
0ceeb4e
Update package-lock.json
fregante Jan 22, 2024
155223e
Merge branch 'main' into F/ci/webext-alert
fregante Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion knip.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ const knipConfig = {
// Referenced in global.d.ts
"@total-typescript/ts-reset",
// Referenced in scss files
"webext-base-css",
"compass-mixins",
// Not getting detected by webpack plugin for .storybook/main.js
"style-loader",
Expand Down
177 changes: 142 additions & 35 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@
"use-debounce": "^10.0.0",
"use-sync-external-store": "^1.2.0",
"uuid": "^9.0.1",
"webext-base-css": "^1.4.4",
"webext-content-scripts": "^2.6.1",
"webext-detect-page": "^5.0.0",
"webext-inject-on-install": "^2.0.0",
Expand Down
4 changes: 2 additions & 2 deletions src/background/browserAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

import { ensureContentScript } from "@/background/contentScript";
import { rehydrateSidebar } from "@/contentScript/messenger/api";
import webextAlert from "./webextAlert";
import { browserAction, type Tab } from "@/mv3/api";
import { executeScript, isScriptableUrl } from "webext-content-scripts";
import { memoizeUntilSettled } from "@/utils/promiseUtils";
Expand Down Expand Up @@ -62,7 +61,8 @@ async function _toggleSidebar(tabId: number, tabUrl: string): Promise<void> {
try {
await sidebarTogglePromise;
} catch (error) {
webextAlert(ERR_UNABLE_TO_OPEN);
// eslint-disable-next-line no-alert -- Intentional usage, no alternative UI
alert(ERR_UNABLE_TO_OPEN);
throw error;
}

Expand Down
26 changes: 0 additions & 26 deletions src/background/webextAlert.ts
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions src/tinyPages/alert.html
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions src/tinyPages/alert.scss
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions src/tinyPages/alert.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/tsconfig.strictNullChecks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"./background/externalProtocol.ts",
"./background/partnerTheme.ts",
"./background/toolbarBadge.ts",
"./background/webextAlert.ts",
"./background/setToolbarBadge.test.ts",
"./bricks/available.ts",
"./bricks/effects/cancel.ts",
Expand Down
1 change: 0 additions & 1 deletion webpack.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ const createConfig = (env, options) =>

// Tiny files without imports
"tinyPages/frame",
"tinyPages/alert",
"tinyPages/devtools",

// The script that gets injected into the host page
Expand Down
Loading