Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc/metrics: Integrate sarama producer metrics (#4520) #4575

Merged
merged 4 commits into from
Feb 22, 2022
Merged

cdc/metrics: Integrate sarama producer metrics (#4520) #4575

merged 4 commits into from
Feb 22, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4520

What problem does this PR solve?

Issue Number: close #4561

What is changed and how it works?

add sarama metrics to prometheus, and monitored by grafana.

  • fetch go-metrics periodically from sarama, and then refresh the prometheus metrics.

Check List

Tests

  • No code
    sHaCmLcFdH

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note 

`None`.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved component/metrics-logging Metrics and logging component. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. labels Feb 11, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 11, 2022
Merged
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. label Feb 11, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 21, 2022
@3AceShowHand
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 0c3fe4a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2022
@ti-chi-bot ti-chi-bot merged commit d02c40c into pingcap:release-5.4 Feb 22, 2022
@3AceShowHand 3AceShowHand mentioned this pull request Feb 22, 2022
Closed
@overvenus overvenus added this to the v5.4.1 milestone Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@3AceShowHand 3AceShowHand

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/metrics-logging Metrics and logging component. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
v5.4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @3AceShowHand @overvenus @VelocityLight