Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc/sink: kafka sink integrate broker level metrics #4517

Merged
merged 68 commits into from
Feb 15, 2022
Merged

cdc/sink: kafka sink integrate broker level metrics #4517

merged 68 commits into from
Feb 15, 2022

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Feb 8, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4588

What is changed and how it works?

add broker level metrics

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Screen Shot 2022-02-14 at 3 21 31 PM

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 8, 2022
@3AceShowHand 3AceShowHand added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2022
@3AceShowHand 3AceShowHand marked this pull request as draft February 8, 2022 05:31
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 8, 2022
@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 583f3a6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2022
@ti-chi-bot ti-chi-bot merged commit 28fe713 into pingcap:master Feb 15, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 15, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4517
062baf7 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4590.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 15, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4517
ce937aa 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4591.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 15, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4517
f87b657 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4592.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2022
Closed
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 15, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4517
9f1d4b5 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4593.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2022
Closed
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 15, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4517
38e9e66 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4594.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2022
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 15, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4517
14ee745 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4595.

zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Feb 16, 2022
@3AceShowHand @zhaoxinyu
cdc/sink: kafka sink integrate broker level metrics (pingcap#4517)
d1ce271 
close pingcap#4588
3AceShowHand added a commit to ti-chi-bot/tiflow that referenced this pull request Feb 22, 2022
@3AceShowHand
cdc/sink: kafka sink integrate broker level metrics (pingcap#4517)
df6948d 
close pingcap#4588
ti-chi-bot added a commit that referenced this pull request Feb 23, 2022
@ti-chi-bot
cdc/sink: kafka sink integrate broker level metrics (#4517) (#4594)
334329d 
close #4588
3AceShowHand added a commit to ti-chi-bot/tiflow that referenced this pull request Feb 25, 2022
@3AceShowHand
cdc/sink: kafka sink integrate broker level metrics (pingcap#4517)
c72566d 
close pingcap#4588
3AceShowHand added a commit to ti-chi-bot/tiflow that referenced this pull request Feb 25, 2022
@3AceShowHand
cdc/sink: kafka sink integrate broker level metrics (pingcap#4517)
54b0622 
close pingcap#4588
3AceShowHand added a commit to 3AceShowHand/tiflow that referenced this pull request Feb 25, 2022
@3AceShowHand
Revert "cdc/sink: kafka sink integrate broker level metrics (pingcap#…
9713d42 
…4517) (pingcap#4594)"

This reverts commit 334329d.
3AceShowHand added a commit to 3AceShowHand/tiflow that referenced this pull request Feb 25, 2022
@3AceShowHand
cdc/sink: kafka sink integrate broker level metrics (pingcap#4517)
3e4763f 
close pingcap#4588
3AceShowHand added a commit to 3AceShowHand/tiflow that referenced this pull request Feb 25, 2022
@3AceShowHand
cdc/sink: kafka sink integrate broker level metrics (pingcap#4517)
0af1da9 
close pingcap#4588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@asddongmen asddongmen asddongmen approved these changes

@liuzix liuzix Awaiting requested review from liuzix

@zhaoxinyu zhaoxinyu Awaiting requested review from zhaoxinyu

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add sarama broker level metrics
5 participants
@3AceShowHand @ti-chi-bot @codecov-commenter @asddongmen @overvenus