Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc/sink: kafka sink integrate broker level metrics (#4517) #4594

Merged
merged 12 commits into from
Feb 23, 2022
Merged

cdc/sink: kafka sink integrate broker level metrics (#4517) #4594

merged 12 commits into from
Feb 23, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4517

What problem does this PR solve?

Issue Number: close #4588

What is changed and how it works?

add broker level metrics

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Screen Shot 2022-02-14 at 3 21 31 PM

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note 

`None`.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2022
Merged
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR. labels Feb 15, 2022
@overvenus overvenus added this to the v5.3.1 milestone Feb 16, 2022
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 18, 2022
@3AceShowHand
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: e1b4499

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2022
@3AceShowHand
Copy link
Contributor

/run-unit-test
/run-leak-test

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2022
@3AceShowHand
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 43464f0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2022
@3AceShowHand
Copy link
Contributor

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit 334329d into pingcap:release-5.3 Feb 23, 2022
3AceShowHand added a commit to 3AceShowHand/tiflow that referenced this pull request Feb 25, 2022
@3AceShowHand
Revert "cdc/sink: kafka sink integrate broker level metrics (pingcap#…
9713d42 
…4517) (pingcap#4594)"

This reverts commit 334329d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@3AceShowHand 3AceShowHand

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR.
Projects
None yet
Milestone
v5.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @3AceShowHand @overvenus @zhouqiang-cl