Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc/metrics: Integrate sarama producer metrics #4520

Merged
merged 48 commits into from
Feb 11, 2022
Merged

cdc/metrics: Integrate sarama producer metrics #4520

merged 48 commits into from
Feb 11, 2022

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Feb 8, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4561

What is changed and how it works?

add sarama metrics to prometheus, and monitored by grafana.

  • fetch go-metrics periodically from sarama, and then refresh the prometheus metrics.

Check List

Tests

  • No code
    sHaCmLcFdH

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 8, 2022
@3AceShowHand 3AceShowHand marked this pull request as draft February 8, 2022 08:04
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 8, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2022
@3AceShowHand
Copy link
Contributor Author

/run-dm-integration-test /tidb=pr/32081

@ti-chi-bot
Copy link
Member

@3AceShowHand: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3AceShowHand
Copy link
Contributor Author

/run-verify-ci /tidb=pr/32081

@ti-chi-bot ti-chi-bot merged commit 8a709d7 into pingcap:master Feb 11, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 11, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4520
e85952e 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 11, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4570.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 11, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4520
69615c2 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4571.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 11, 2022
Closed
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 11, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4520
f903826 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 11, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4572.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 11, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4520
6cef8e2 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4573.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 11, 2022
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 11, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4520
d3290c6 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 11, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4574.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 11, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4520
e666fab 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 11, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4575.

zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Feb 16, 2022
@3AceShowHand @zhaoxinyu
cdc/metrics: Integrate sarama producer metrics (pingcap#4520)
777712f 
close pingcap#4561
ti-chi-bot added a commit that referenced this pull request Feb 22, 2022
@ti-chi-bot
cdc/metrics: Integrate sarama producer metrics (#4520) (#4574)
1400e37 
close #4561
ti-chi-bot added a commit that referenced this pull request Feb 22, 2022
@ti-chi-bot
cdc/metrics: Integrate sarama producer metrics (#4520) (#4575)
d02c40c 
close #4561
3AceShowHand added a commit to 3AceShowHand/tiflow that referenced this pull request Feb 25, 2022
@3AceShowHand
Revert "cdc/metrics: Integrate sarama producer metrics (pingcap#4520) (…
be159ce 
…pingcap#4574)"

This reverts commit 1400e37.
3AceShowHand added a commit to 3AceShowHand/tiflow that referenced this pull request Feb 25, 2022
@3AceShowHand
cdc/metrics: Integrate sarama producer metrics (pingcap#4520)
721def0 
close pingcap#4561
3AceShowHand added a commit to 3AceShowHand/tiflow that referenced this pull request Feb 25, 2022
@3AceShowHand
cdc/metrics: Integrate sarama producer metrics (pingcap#4520)
e681cf3 
close pingcap#4561
ti-chi-bot added a commit that referenced this pull request Feb 25, 2022
@ti-chi-bot
cdc/metrics: Integrate sarama producer metrics (#4520) (#4573)
2817747 
close #4561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@zhaoxinyu zhaoxinyu zhaoxinyu approved these changes

@asddongmen asddongmen asddongmen approved these changes

@liuzix liuzix Awaiting requested review from liuzix

@sdojjy sdojjy Awaiting requested review from sdojjy

@amyangfei amyangfei Awaiting requested review from amyangfei

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

Assignees
No one assigned
Labels
component/metrics-logging Metrics and logging component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add kafka producer metrics
7 participants
@3AceShowHand @ti-chi-bot @asddongmen @codecov-commenter @zhaoxinyu @amyangfei @overvenus