Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: forbid aggregate function with json type pushdown to tiflash wrongly #36271

Merged
merged 12 commits into from
Jul 18, 2022

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Jul 18, 2022

What problem does this PR solve?

Issue Number: close #28753

Problem Summary:

What is changed and how it works?

Now tiflash support 8 aggregate function: Sum, Count, Min, Max, Avg, FirstRow, ApproxCountDistinct, GroupConcat
5 aggregate function is no need cast Agg funcs: Min, Max, FirstRow, Count, ApproxCountDistinct
3 aggregate function may exist implicit conversions: Sum, Avg(convert to Real), GroupConcat(convert to String)
All types except Duration and JSON are supported to convert to Real and String.
So we can prohibit the aggregate with json type pushing down.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Before this pr
use test;
drop table t;
create table t(a json);
insert into t values(null);
alter table t set tiflash replica 1;
select avg(a) from t;
ERROR 1105 (HY000): other error for mpp stream: Code: 0, e.displayText() = DB::TiFlashException: CastJsonAsReal is not supported., e.what() = DB::TiFlashException,
select sum(a) from t;
ERROR 1105 (HY000): other error for mpp stream: Code: 0, e.displayText() = DB::TiFlashException: CastJsonAsReal is not supported., e.what() = DB::TiFlashException,
select /*+ hash_agg() */  group_concat(a) from t;
ERROR 1105 (HY000): other error for mpp stream: Code: 0, e.displayText() = DB::TiFlashException: CastJsonAsString is not supported., e.what() = DB::TiFlashException,

After this pr
All the sum/avg/group_concat with json type can't push down to tiflash.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 18, 2022

@wshwsh12 wshwsh12 requested review from XuHuaiyu and windtalker July 18, 2022 08:07
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may add a test like TestReverseUTF8PushDownToTiFlash ?

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2022
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 18, 2022
@wshwsh12
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a736219

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 18, 2022
@ti-chi-bot ti-chi-bot merged commit de017e9 into pingcap:master Jul 18, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 18, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #36286

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 18, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #36287

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 18, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #36288

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 18, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #36289

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 18, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #36290

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 18, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #36291

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 18, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #36292

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 18, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #36293

@sre-bot
Copy link
Contributor

sre-bot commented Jul 18, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 22 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 8 min 1 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 54 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 1 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 42 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 23 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 32 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CastTimeAsReal was pushed down to tiflash by mistake
7 participants