-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: forbid aggregate function with json type pushdown to tiflash wrongly #36271
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
b01555b
to
f59e72e
Compare
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/39172703766fb3231ec3a3b2892bb7df6063b3de |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may add a test like TestReverseUTF8PushDownToTiFlash
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a736219
|
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #36286 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.0 in PR #36287 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.1 in PR #36288 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.2 in PR #36289 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.3 in PR #36290 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.4 in PR #36291 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-6.0 in PR #36292 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-6.1 in PR #36293 |
TiDB MergeCI notify
|
What problem does this PR solve?
Issue Number: close #28753
Problem Summary:
What is changed and how it works?
Now tiflash support 8 aggregate function: Sum, Count, Min, Max, Avg, FirstRow, ApproxCountDistinct, GroupConcat
5 aggregate function is no need cast Agg funcs: Min, Max, FirstRow, Count, ApproxCountDistinct
3 aggregate function may exist implicit conversions: Sum, Avg(convert to Real), GroupConcat(convert to String)
All types except Duration and JSON are supported to convert to Real and String.
So we can prohibit the aggregate with json type pushing down.
Check List
Tests
Before this pr
After this pr
All the sum/avg/group_concat with json type can't push down to tiflash.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.