Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: forbid aggregate function with json type pushdown to tiflash wrongly #36271

Merged
merged 12 commits into from
Jul 18, 2022
Merged

expression: forbid aggregate function with json type pushdown to tiflash wrongly #36271

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f59e72e
fix
wshwsh12 Jul 18, 2022
a736219
add ut
wshwsh12 Jul 18, 2022
49a7114
Merge branch 'master' into wrongly-pushdown-2
ti-chi-bot Jul 18, 2022
a49f1d7
Merge branch 'master' into wrongly-pushdown-2
ti-chi-bot Jul 18, 2022
6910512
enable revive for expression/aggregation
hawkingrei Jul 18, 2022
de7f570
disable revive for expression/aggregation
hawkingrei Jul 18, 2022
b895b0d
Merge branch 'master' into wrongly-pushdown-2
ti-chi-bot Jul 18, 2022
6ff91d5
Merge branch 'master' into wrongly-pushdown-2
ti-chi-bot Jul 18, 2022
991e96a
Merge branch 'master' into wrongly-pushdown-2
hawkingrei Jul 18, 2022
38d8208
Merge branch 'master' into wrongly-pushdown-2
ti-chi-bot Jul 18, 2022
717ea90
Merge branch 'master' into wrongly-pushdown-2
hawkingrei Jul 18, 2022
3917270
Merge branch 'master' into wrongly-pushdown-2
ti-chi-bot Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion expression/aggregation/aggregation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,11 @@ func CheckAggPushFlash(aggFunc *AggFuncDesc) bool {
}
}
switch aggFunc.Name {
case ast.AggFuncSum, ast.AggFuncCount, ast.AggFuncMin, ast.AggFuncMax, ast.AggFuncAvg, ast.AggFuncFirstRow, ast.AggFuncApproxCountDistinct, ast.AggFuncGroupConcat:
case ast.AggFuncCount, ast.AggFuncMin, ast.AggFuncMax, ast.AggFuncFirstRow, ast.AggFuncApproxCountDistinct:
return true
case ast.AggFuncSum, ast.AggFuncAvg, ast.AggFuncGroupConcat:
// Now tiflash doesn't support CastJsonAsReal and CastJsonAsString.
return aggFunc.Args[0].GetType().GetType() != mysql.TypeJSON
}
return false
}