expression: forbid aggregate function with json type pushdown to tiflash wrongly (#36271) #36293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #36271 to release-6.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/36293
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #28753
Problem Summary:
What is changed and how it works?
Now tiflash support 8 aggregate function: Sum, Count, Min, Max, Avg, FirstRow, ApproxCountDistinct, GroupConcat
5 aggregate function is no need cast Agg funcs: Min, Max, FirstRow, Count, ApproxCountDistinct
3 aggregate function may exist implicit conversions: Sum, Avg(convert to Real), GroupConcat(convert to String)
All types except Duration and JSON are supported to convert to Real and String.
So we can prohibit the aggregate with json type pushing down.
Check List
Tests
Before this pr
After this pr
All the sum/avg/group_concat with json type can't push down to tiflash.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.