Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: support partition selection grammer for the delete statement #868

Merged
merged 1 commit into from
May 22, 2020

Conversation

tiancaiamao
Copy link
Collaborator

What problem does this PR solve?

Support delete from t partition (p0,p1) ...

What is changed and how it works?

update parser.y

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@tiancaiamao tiancaiamao requested a review from a team May 22, 2020 08:12
@ghost ghost requested review from kennytm and removed request for a team May 22, 2020 08:12
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #868 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #868   +/-   ##
=======================================
  Coverage   78.30%   78.30%           
=======================================
  Files          40       40           
  Lines       14681    14682    +1     
=======================================
+ Hits        11496    11497    +1     
  Misses       2502     2502           
  Partials      683      683           

@tiancaiamao
Copy link
Collaborator Author

PTAL @XuHuaiyu @imtbkcat

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Collaborator Author

/rebuild

@kennytm kennytm added the status/LGT1 LGT1 label May 22, 2020
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels May 22, 2020
@tiancaiamao tiancaiamao merged commit 3b720a0 into pingcap:master May 22, 2020
@tiancaiamao tiancaiamao deleted the delete-partition-selection branch May 22, 2020 09:49
@sre-bot
Copy link

sre-bot commented May 22, 2020

cherry pick to release-4.0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants