Fix set charset statement
#836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
==========================================
+ Coverage 78.28% 78.36% +0.08%
==========================================
Files 40 40
Lines 14665 14759 +94
==========================================
+ Hits 11480 11566 +86
- Misses 2502 2512 +10
+ Partials 683 681 -2 |
|
LGTM |
tiancaiamao
approved these changes
Apr 28, 2020
|
/rebuild |
AilinKid
pushed a commit
to AilinKid/parser
that referenced
this pull request
Jun 1, 2020
AilinKid
added a commit
that referenced
this pull request
Jun 2, 2020
|
/run-cherry-picker |
|
cherry pick to release-4.0 failed |
1 similar comment
|
cherry pick to release-4.0 failed |
|
/run-cherry-picker |
|
cherry pick to release-4.0 failed |
wjhuang2016
added a commit
to wjhuang2016/parser
that referenced
this pull request
Jul 8, 2020
wjhuang2016
added a commit
that referenced
this pull request
Jul 8, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
set charsetstatement is not equal toset namesstatement, we need to distinguish them.Related TiDB PR.
What is changed and how it works?
If the statement is
set charset, we useSetCharsetinstead ofSetNamesto mark it.Check List
Tests
Code changes
Side effects
Related changes