Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: support partition selection grammer for the delete statement (#868) #870

Merged
merged 1 commit into from
May 25, 2020
Merged

parser: support partition selection grammer for the delete statement (#868) #870

merged 1 commit into from
May 25, 2020

Conversation

tiancaiamao
Copy link
Collaborator

@tiancaiamao tiancaiamao commented May 25, 2020 •
edited
Loading

Cherry pick #868 to release-4.0

@tiancaiamao tiancaiamao requested a review from a team May 25, 2020 05:48
@ghost ghost requested review from tangenta and removed request for a team May 25, 2020 05:48
@tiancaiamao
Copy link
Collaborator Author

PTAL @jackysp @kennytm

jackysp
jackysp reviewed May 25, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT2 LGT2 label May 25, 2020
@tiancaiamao tiancaiamao merged commit f45c2ce into pingcap:release-4.0 May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@kennytm kennytm kennytm approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
status/LGT2 LGT2 type/cherry-pick-for-release-4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiancaiamao @kennytm @jackysp