parser: add opt_rule_blacklist and admin reload it.
#375
Conversation
|
|
lzmhhh123
force-pushed
the
dev/add_logical_rule_disabled_list
branch
from
317d444 to
c880464
Compare
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 70.11% 70.09% -0.02%
==========================================
Files 32 32
Lines 7394 7396 +2
==========================================
Hits 5184 5184
- Misses 1698 1700 +2
Partials 512 512
Continue to review full report at Codecov.
|
lzmhhh123
force-pushed
the
dev/add_logical_rule_disabled_list
branch
from
226ca7c to
3f9771f
Compare
lzmhhh123
changed the title
admin reload it.
misc.go
Outdated
| @@ -589,6 +589,7 @@ var tokenMap = map[string]int{ | |||
| "BINDING": binding, | |||
| "BINDINGS": bindings, | |||
| "EXPR_PUSHDOWN_BLACKLIST": exprPushdownBlacklist, | |||
| "DISABLED_OPTIMIZE_LIST": disabledOptimizeList, | |||
There was a problem hiding this comment.
Better to keep the same naming pattern. How about OPT_RULE_BLACKLIST?
There was a problem hiding this comment.
It contains expression push down and other things like cascade rules in the future besides logical rules. Shall we also change the name?
There was a problem hiding this comment.
I prefer to let this table to only contain the disabled rules. This makes the PR can be cherry-picked to release-3.0 and don't need to worry about the compatibility problems.
There was a problem hiding this comment.
OK, if that's so. I should change it.
…om/lzmhhh123/parser into dev/add_logical_rule_disabled_list
lzmhhh123
changed the title
admin reload it.admin reload it.
What problem does this PR solve?
Refer to: pingcap/tidb#11096
What is changed and how it works?
Just add an
admin reloadin the parser and a new word in the ast.Check List
Tests
Code changes
Related changes