Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*:add opt_rule_blacklist in mysql tables. #11096

Merged
merged 14 commits into from
Jul 24, 2019
Merged

*:add opt_rule_blacklist in mysql tables. #11096

merged 14 commits into from
Jul 24, 2019

Conversation

lzmhhh123
Copy link
Contributor

@lzmhhh123 lzmhhh123 commented Jul 5, 2019 •
edited
Loading

What problem does this PR solve?

In some product environments. We found that a switch to disable some logical optimizing rules is convenient for troubleshooting.

What is changed and how it works?

Like expr_pushdown_blacklist, just add a opt_rule_blacklist.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to update the documentation

@lzmhhh123
Copy link
Contributor Author

/run-unit-test

@lzmhhh123 lzmhhh123 force-pushed the dev/add_switch_for_rules branch from 378c555 to e153d24 Compare July 8, 2019 09:50
@lzmhhh123 lzmhhh123 mentioned this pull request Jul 8, 2019
Merged
@lzmhhh123 lzmhhh123 changed the title *: add session/global variables to disable some logical rules for some test situations. *:add disable_logical_rules field and change mysql.blacklist table. Jul 8, 2019
@lzmhhh123 lzmhhh123 force-pushed the dev/add_switch_for_rules branch from 89e5915 to b299cf9 Compare July 8, 2019 11:42
@lzmhhh123
Copy link
Contributor Author

/rebuild

@codecov
Copy link

codecov bot commented Jul 9, 2019 •
edited
Loading

Codecov Report

Merging #11096 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11096   +/-   ##
===========================================
  Coverage   81.3666%   81.3666%           
===========================================
  Files           424        424           
  Lines         90730      90730           
===========================================
  Hits          73824      73824           
  Misses        11594      11594           
  Partials       5312       5312

@lzmhhh123 lzmhhh123 force-pushed the dev/add_switch_for_rules branch from ef642be to cec51f1 Compare July 9, 2019 06:27
@lzmhhh123
Copy link
Contributor Author

/rebuild

@lzmhhh123 lzmhhh123 force-pushed the dev/add_switch_for_rules branch from cec51f1 to 7a378d5 Compare July 9, 2019 06:34
@lzmhhh123 lzmhhh123 changed the title *:add disable_logical_rules field and change mysql.blacklist table. *:add opt_rule_blacklist in mysql tables. Jul 16, 2019
zz-jason
zz-jason reviewed Jul 17, 2019
View reviewed changes
planner/core/optimizer.go Outdated Show resolved Hide resolved
planner/core/optimizer.go Outdated Show resolved Hide resolved
executor/reload_expr_pushdown_blacklist.go Outdated Show resolved Hide resolved
executor/disabled_optimize_list.go Outdated Show resolved Hide resolved
executor/disabled_optimize_list_test.go Outdated Show resolved Hide resolved
zz-jason
zz-jason reviewed Jul 17, 2019
View reviewed changes
session/bootstrap.go Outdated Show resolved Hide resolved
alivxxx
alivxxx reviewed Jul 18, 2019
View reviewed changes
session/bootstrap.go Outdated Show resolved Hide resolved
alivxxx
alivxxx reviewed Jul 18, 2019
View reviewed changes
go.mod Outdated Show resolved Hide resolved
zz-jason
zz-jason reviewed Jul 19, 2019
View reviewed changes
executor/opt_rule_blacklist_test.go Outdated Show resolved Hide resolved
executor/reload_expr_pushdown_blacklist.go Outdated Show resolved Hide resolved
session/bootstrap.go Outdated Show resolved Hide resolved
@zz-jason
Copy link
Member

BTW, we need to document all the rules which can be disabled for users.

zz-jason
zz-jason reviewed Jul 24, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 24, 2019
alivxxx
alivxxx approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 24, 2019
@alivxxx
Copy link
Contributor

alivxxx commented Jul 24, 2019

/run-all-tests

@lzmhhh123 lzmhhh123 merged commit f891204 into pingcap:master Jul 24, 2019
@lzmhhh123 lzmhhh123 deleted the dev/add_switch_for_rules branch July 24, 2019 05:36
lzmhhh123 added a commit to lzmhhh123/tidb that referenced this pull request Aug 7, 2019
@lzmhhh123
*:add opt_rule_blacklist in mysql tables. (pingcap#11096)
f8e7418
@lzmhhh123 lzmhhh123 mentioned this pull request Aug 7, 2019
Merged
sre-bot pushed a commit that referenced this pull request Aug 7, 2019
@lzmhhh123 @sre-bot
*: add opt_rule_blacklist in mysql tables. (#11096) (#11658)
eca09b1
@lzmhhh123 lzmhhh123 mentioned this pull request Apr 23, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@alivxxx alivxxx alivxxx approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/new-feature type/usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzmhhh123 @zz-jason @alivxxx @XuHuaiyu