Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: add opt_rule_blacklist and admin reload it (#375) #397

Merged
merged 2 commits into from
Aug 6, 2019
Merged

parser: add opt_rule_blacklist and admin reload it (#375) #397

merged 2 commits into from
Aug 6, 2019

Conversation

lzmhhh123
Copy link
Contributor

cherry-pick #375
#375: parser: add opt_rule_blacklist and admin reload it.

@lzmhhh123 lzmhhh123 changed the title parser: add opt_rule_blacklist and admin reload it (#375) [3.0] parser: add opt_rule_blacklist and admin reload it (#375) Jul 25, 2019
@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-3.0@d4d0733). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-3.0     #397   +/-   ##
==============================================
  Coverage               ?   52.86%           
==============================================
  Files                  ?       31           
  Lines                  ?     6604           
  Branches               ?        0           
==============================================
  Hits                   ?     3491           
  Misses                 ?     2771           
  Partials               ?      342
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø)
misc.go 96.42% <ø> (ø)
ast/misc.go 17.92% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d0733...41a1b69. Read the comment docs.

@lzmhhh123 lzmhhh123 requested review from zz-jason, qw4990 and alivxxx July 25, 2019 11:21
@zz-jason zz-jason changed the title [3.0] parser: add opt_rule_blacklist and admin reload it (#375) parser: add opt_rule_blacklist and admin reload it (#375) Jul 25, 2019
zz-jason
zz-jason reviewed Jul 25, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alivxxx
alivxxx reviewed Jul 25, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 LGT1 label Jul 25, 2019
alivxxx
alivxxx previously approved these changes Jul 25, 2019
View reviewed changes
@alivxxx alivxxx added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Jul 25, 2019
@kennytm
Copy link
Contributor

kennytm commented Jul 25, 2019

The protected branch setting is wrong. The required check should be ci/circleci: build-ut instead of ci/circleci: build for the release-3.0 branch. cc @tiancaiamao

@lzmhhh123 lzmhhh123 removed the request for review from qw4990 July 26, 2019 05:38
@kennytm kennytm merged commit 1a31cab into pingcap:release-3.0 Aug 6, 2019
@lzmhhh123 lzmhhh123 deleted the release-3.0-cherry-pick-375 branch August 6, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@kennytm kennytm kennytm approved these changes

@alivxxx alivxxx alivxxx left review comments

Assignees
No one assigned
Labels
status/LGT2 LGT2 type/cherry-pick-for-release-3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzmhhh123 @kennytm @zz-jason @alivxxx