-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor data conversion errors and diagnostics, tests, headers and test data directory #91
Conversation
@t-kataym, this simple PR is ready for review. |
92d3572
to
3835967
Compare
db0c010
to
eb992da
Compare
@t-kataym , could you please write approximate week of review of this PR? Have pgspider team any plans of a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for your contribution.
I have some comments for your PR, could you please check it?
All your comments have checked, please start 2nd round of review, @nxhai98 ! |
out of range
diagnostics, tests, headers and test data directory
out of range
diagnostics, tests, headers and test data directoryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some more comment, could you please check it?
Ping, @nxhai98 ! Are there any results of 2 rounds of your review? What will be later? |
@t-kataym , could you please write approximate week of review and status of this PR? Will there 3rd review round? |
Hello @t-kataym and @nxhai98 ! Any chances to have feedback or 3rd review round for this PR? What is the status of this PR? Completely PR description after checking all your comments was updated #91 (comment) |
In this PR:
integer
-family out of range checks. SQLiteint
affinity is 1↔1 with PostgreSQLbigint
and also have equal ranges. If we haveint
orsmallint
in PostgreSQL some input values which is out of range for this data types are possible.sqlite3_column_@(stmt, colid)
functions inside ofsqlite_convert_to_pg
replaced tosqlite3_value_@(val)
functions for less parameters and fastest calculations, seesqlite3_value *sqlite3_column_value(sqlite3_stmt *pStmt, int i
) andstatic Mem *columnMem(sqlite3_stmt *pStmt, int i)
which will calculated once instead of manysqlite3_column_@(stmt, colid)
calls.out_of_range
test fromint4
, addint2
TCs 641c539.bigint
PostgreSQL column can come a value withreal
affinity which is out of range. Add PostgreSQL input core function and TCs for this case.ErrorContextCallback
function with universal messages about any data conversion problems between PostgreSQL data column and SQLite data value.bitstring
test fromtype
test 9bc53a4.dtof
tofloat4
PostgreSQL data column branch f0593de (without testing, will tested in other PR about fullreal
affinity support)./tmp/sqlite_fdw_test
directory for less chaos in/tmp
cbba043 . This allow reduce testing time.ForeignTable
andForeignServer
into...State
structures, because this variables are often calculated near this structures in functions like constructor. f1a1f89