Restore bit and varbit support with tests

[mkgrgis]

PostgreSQL bit and varbit dataypes based on SQLite integer affinity, hence maximum length for current implementation is 64 bits. There was untested bit and varbit support in early releases, which was regressed to some fragments of code.

[nxhai98]

I have some comments for your PR. Please help me to check this.

[nxhai98]

I added some more comment for you modify. Please help me to check it.

[nxhai98]

@mkgrgis,
I executed test for your branch and there is a failed test (for all versions):

@@ -1155,7 +1155,7 @@
--- postgresql-12.15/contrib/sqlite_fdw/expected/12.15/type.out
+++ postgresql-12.15/contrib/sqlite_fdw/results/12.15/type.out
 --Testcase 238: very long bit string, expected ERROR, 65 bits
 INSERT INTO "type_VARBIT" ("i", "b") VALUES (14, '01001001010110010100101010001111101101011011011110110001010101010');
 ERROR:  SQLite FDW dosens't support very long bit/varbit data
-HINT:  bit length 65, maxmum 64
+HINT:  bit length 65, maximum 64
 --Testcase 239:

Could you fix this?

[mkgrgis]

Could you fix this?

Thanks, @nxhai98 ! Fixed in d5e1fea, I am sorry. Look like this PR is ready for merging.

[nxhai98]

Thank you for fixing. I confirmed in my environment. All tests are passed.

[mkgrgis]

@t-kataym , your opinion?

[mkgrgis]

@nxhai98 , could you please ask @t-kataym -san about decision about this PR? I want to be in work rhythm with pgspider team but don't understand review plans of the team for PRs from github. For example now I have made two parallel simple PRs with arbitrary review order #89 (testing scripts) and #91 (int overflow). Also I have continued datatype grid normalisation to ISO:SQL in complicated PR #88 which will base for yet drafted and tested "UUID fix" and "float infinity" PRs. Could anyone please give me approximately time milestones?

[t-kataym]

@mkgrgis I'm sorry for late response. I didn't have not enough time.

We confirmed the PR. Is it no problem to merge it into master?

[mkgrgis]

No problems to merge. Maybe in squashed form if You want, @t-kataym. Thanks.

[t-kataym]

@mkgrgis Thank you. I will merge it.