Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiversional testing scripts #89

Closed
wants to merge 3 commits into from

Conversation

mkgrgis
Copy link
Contributor

@mkgrgis mkgrgis commented Nov 13, 2023

This scripts allows automatically get multiversional PostgreSQL source codes from official PGDG repository. With some untested limitations this is applicable also to other pgspider FDWs with ./test.sh script in root source code directory.

No C-language review, please let review by compilation environment infrastructure engineers.

@t-kataym
Copy link
Contributor

@mkgrgis , Thank you for the PR.
Please let me share our opinion.
The source code of testing target is downloaded from GitHub. It means that your scripts can be run outside of sqlite_fdw.
FDWs in our projects support multi versions of PostgreSQL as same as sqlite_fdw.
We think your scripts is useful for the other our FDWs.
So we would like to create a new repository in PGSpider project and put your scripts in if you agree.

@mkgrgis
Copy link
Contributor Author

mkgrgis commented Nov 30, 2023

Yes, I am agree, @t-kataym ! Please only describe me as author of this first edition of the scripts.

@mkgrgis
Copy link
Contributor Author

mkgrgis commented Nov 30, 2023

pgspider/testing_scripts ?

@t-kataym
Copy link
Contributor

t-kataym commented Dec 1, 2023

@mkgrgis , We would like to proceed with the following steps if you agree. It can indicate that you are the first author of the scripts.

  1. You publish these scripts as OSS on GItHub repository on your account. We expect the license is PostgreSQL License.
  2. We fork your repository into PGSpider project.
  3. You create PR on our repository if you need.

@mkgrgis
Copy link
Contributor Author

mkgrgis commented Dec 1, 2023

Thanks, @t-kataym ! All is done https://github.com/mkgrgis/fdw_testing_scripts , please fork and use. You can close this PR after this as implemented in other way.

@t-kataym
Copy link
Contributor

t-kataym commented Dec 1, 2023

@mkgrgis , Thank you for your understanding.
Could you remove the our name "Toshiba Corporation" from Copyright because only you created scripts and we didn't do anything for the scripts now?
When we modify the source code or comment the PR, we would like to append our name to Copyright.

@mkgrgis
Copy link
Contributor Author

mkgrgis commented Dec 1, 2023

Could you remove the our name "Toshiba Corporation" from Copyright because only you created scripts and we didn't do anything for the scripts now?

Yes, fixed. Please verify.

@t-kataym
Copy link
Contributor

t-kataym commented Dec 1, 2023

@mkgrgis , Thank you for fixing and your contribution.
I forked your repository just now.
https://github.com/pgspider/fdw_testing_scripts

So I would like to close the PR.

@t-kataym t-kataym closed this Dec 1, 2023
@mkgrgis mkgrgis deleted the testing_scripts branch December 1, 2023 08:55
@mkgrgis
Copy link
Contributor Author

mkgrgis commented Dec 1, 2023

Thanks for accepting my contribution. @t-kataym !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants