-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RELEASE_v2.4.0-test #93
Conversation
|
||
DROP FOREIGN TABLE "Unicode data"; | ||
DROP SERVER sqlite_svr; | ||
DROP EXTENSION sqlite_fdw; | ||
-- euc_jp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is encodings
test artefacts moved to encodings.sql. Also this is applicable to other versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry. This is not encodings
test artifacts, SELECT * FROM "Unicode data";
also was moved to this test. Thanks, @MinhLA1410 ! I haven't expect this optimization. All is ok.
Hello, @MinhLA1410 , please refer https://github.com/pgspider/sqlite_fdw/compare/master...mkgrgis:sqlite_fdw:fix_uuid_and_tests?expand=1 file changes where I have unify |
@t-kataym , no problems. I have scripts to unify tests between versions. Also I think it's important to delete
Hence rebasing of #88 will be more productive for me in case of @MinhLA1410 will delete this artefacts now. It is yet results of last unsuccessful test rebasing with unification and version updating. |
@mkgrgis, Do you want to remove this section? (https://github.com/pgspider/sqlite_fdw/pull/93/files#diff-d52fef6eb88d3a0df647c84e6a43d1f0cc573269296110d6207f22d7edcc13e5R38) |
|
||
--Testcase 151: | ||
DROP SERVER sqlite_svr; | ||
--Testcase 152: | ||
DROP EXTENSION sqlite_fdw CASCADE; | ||
|
||
-- tests for PR #76 github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yet deleted encodings
test artifacts, no problems.
No, @MinhLA1410 . Please refer a full |
@mkgrgis , @MinhLA1410 Thank you for confirming the PR and discussing. |
Changes: