Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELEASE_v2.4.0-test #93

Merged
merged 1 commit into from
Dec 27, 2023
Merged

RELEASE_v2.4.0-test #93

merged 1 commit into from
Dec 27, 2023

Conversation

MinhLA1410
Copy link
Contributor

Changes:

  • support PostgreSQL 12.16, 13.12, 14.9, 15.4 and 16.0
  • synchronize test code between versions.


DROP FOREIGN TABLE "Unicode data";
DROP SERVER sqlite_svr;
DROP EXTENSION sqlite_fdw;
-- euc_jp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is encodings test artefacts moved to encodings.sql. Also this is applicable to other versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry. This is not encodings test artifacts, SELECT * FROM "Unicode data"; also was moved to this test. Thanks, @MinhLA1410 ! I haven't expect this optimization. All is ok.

@mkgrgis
Copy link
Contributor

mkgrgis commented Dec 22, 2023

Hello, @MinhLA1410 , please refer https://github.com/pgspider/sqlite_fdw/compare/master...mkgrgis:sqlite_fdw:fix_uuid_and_tests?expand=1 file changes where I have unify uuid, bool, bitstring and encodings tests. This is draft branch for PR after #88 and #91. You have got encodings test artefacts. It was yet moved to separate encodings test but not completely. I am sorry, my test normalisation was planned later than this your PR.

@t-kataym
Copy link
Contributor

@mkgrgis Please let me merge the PR #93 first. You are familiar with refactoring the test code, could you rebase #88 and #91? I'm sorry for bothering you.

@mkgrgis
Copy link
Contributor

mkgrgis commented Dec 25, 2023

@t-kataym , no problems. I have scripts to unify tests between versions.

Also I think it's important to delete encodings test artefacts in this PR. In #88 also there is

Remove encodings test artefacts from sqlite_fdw main test with PG 15 and 16.

Hence rebasing of #88 will be more productive for me in case of @MinhLA1410 will delete this artefacts now. It is yet results of last unsuccessful test rebasing with unification and version updating.

@MinhLA1410
Copy link
Contributor Author


--Testcase 151:
DROP SERVER sqlite_svr;
--Testcase 152:
DROP EXTENSION sqlite_fdw CASCADE;

-- tests for PR #76 github
Copy link
Contributor

@mkgrgis mkgrgis Dec 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet deleted encodings test artifacts, no problems.

@mkgrgis
Copy link
Contributor

mkgrgis commented Dec 26, 2023

@mkgrgis, Do you want to remove this section? (https://github.com/pgspider/sqlite_fdw/pull/93/files#diff-d52fef6eb88d3a0df647c84e6a43d1f0cc573269296110d6207f22d7edcc13e5R38)

No, @MinhLA1410 . Please refer a full encodings test files https://github.com/mkgrgis/sqlite_fdw/blob/fix_uuid_and_tests/expected/16.0/extra/encodings.out and https://github.com/mkgrgis/sqlite_fdw/blob/fix_uuid_and_tests/sql/16.0/extra/encodings.sql . In your PR this files is also in normal form, no problems. Also I see you have deleted doubled test artifacts in sql/16.0/sqlite_fdw.sql hence no problems. I am sorry, this PR is OK. Let's merge, @t-kataym .

@t-kataym
Copy link
Contributor

@mkgrgis , @MinhLA1410 Thank you for confirming the PR and discussing.

@t-kataym t-kataym merged commit 78406b9 into pgspider:master Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants