EngineTest.test_trace_multi is flaky #6829
Labels
Comments
|
Seen again in #6876. |
|
And again fixing flaky #6877. |
|
And again, this time on master and on both python 2 and 3 unit test shards. |
jsirois
added a commit
to jsirois/pants
that referenced
this issue
Dec 11, 2018
The test is known to be inherently flakey as descrbed in pantsbuild#6829.
jsirois
added a commit
that referenced
this issue
Dec 11, 2018
The test is known to be inherently flakey as descrbed in #6829.
jsirois
added a commit
to jsirois/pants
that referenced
this issue
Mar 25, 2020
This brings our skip count up from 7 python and 2 rust to 25 python and 4 rust, hopefully in the name of stability as outlined in pantsbuild#9386. Also updates the How to Contribute docs with a pointer to pantsbuild#9386 for the latest procedure. Includes flaky tests from: pantsbuild#9313 pantsbuild#9312 pantsbuild#8679 pantsbuild#8678 pantsbuild#8520 pantsbuild#8520 pantsbuild#8520 pantsbuild#8405 pantsbuild#8193 pantsbuild#8171 pantsbuild#7836 pantsbuild#7622 pantsbuild#7573 pantsbuild#7572 pantsbuild#7554 pantsbuild#7547 pantsbuild#7457 pantsbuild#7168 pantsbuild#7149 pantsbuild#6838 pantsbuild#6829 pantsbuild#6787 pantsbuild#6114 [ci skip-jvm-tests] # No JVM changes made.
jsirois
added a commit
that referenced
this issue
Mar 25, 2020
This brings our skip count up from 7 python and 2 rust to 25 python and 4 rust, hopefully in the name of stability as outlined in #9386. Also updates the How to Contribute docs with a pointer to #9386 for the latest procedure. Includes flaky tests from: #9313 #9312 #8679 #8678 #8520 #8520 #8520 #8405 #8193 #8171 #7836 #7622 #7573 #7572 #7554 #7547 #7457 #7168 #7149 #6838 #6829 #6787 #6114
|
Closing because this has too much code rot now, so I'm deleting the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Because the root of a request fails fast while additional work continues to run,
tracewill only ever observe two failures simultaneously if multiple failures occur between the time when the root fails and the time whentraceis called. This causes the structure (and semantics) oftest_trace_multito be inherently flaky.One way to fix the test would be to move the test down a level into the
graphcrate. Another way would be to leave the test where it is, and to make the semantics of fast and slow failure more explicit, possibly by adding a pants global option that waits until the graph below a Session's roots have stabilized (no running nodes) before rendering atrace. It might even be a good default (or not require an option at all?)The text was updated successfully, but these errors were encountered: