Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RscCompileIntegration.test_java_with_transitive_exported_scala_dep is flaky #8679

Closed
Eric-Arellano opened this issue Nov 21, 2019 · 2 comments
Closed

RscCompileIntegration.test_java_with_transitive_exported_scala_dep is flaky #8679

Eric-Arellano opened this issue Nov 21, 2019 · 2 comments
Labels
flaky-test

Comments

@Eric-Arellano
Copy link
Contributor 

                     ==================== FAILURES ====================
843                     _ RscCompileIntegration.test_java_with_transitive_exported_scala_dep _
844                     
845                     self = <pants_test.backend.jvm.tasks.jvm_compile.rsc.test_rsc_compile_integration.RscCompileIntegration testMethod=test_java_with_transitive_exported_scala_dep>
846                     args = (), kwargs = {}
847                     strategy = <ExecutionStrategy.subprocess: 'subprocess'>
848                     
849                         def wrapper(self, *args, **kwargs):
850                           for strategy in RscCompile.ExecutionStrategy.all_values():
851                             with environment_as(
852                               HERMETIC_ENV='PANTS_COMPILE_RSC_EXECUTION_STRATEGY',
853                               PANTS_COMPILE_RSC_EXECUTION_STRATEGY=strategy.value,
854                               PANTS_COMPILE_RSC_WORKFLOW=workflow.value,
855                               PANTS_CACHE_COMPILE_RSC_IGNORE='True',
856                               **env_kwargs):
857                     >         f(self, *args, **kwargs)
858                     
859                     pants_test/backend/jvm/tasks/jvm_compile/rsc/rsc_compile_integration_base.py:23: 
860                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
861                     pants_test/backend/jvm/tasks/jvm_compile/rsc/test_rsc_compile_integration.py:29: in test_java_with_transitive_exported_scala_dep
862                         self.do_command('compile', 'testprojects/src/scala/org/pantsbuild/testproject/javadepsonscalatransitive:java-in-different-package')
863                     pants/testutil/pants_run_integration_test.py:650: in do_command
864                         self.assert_success(pants_run)
865                     pants/testutil/pants_run_integration_test.py:487: in assert_success
866                         self.assert_result(pants_run, PANTS_SUCCEEDED_EXIT_CODE, expected=True, msg=msg)
867                     pants/testutil/pants_run_integration_test.py:508: in assert_result
868                         assertion(value, pants_run.returncode, error_msg)
869                     E   AssertionError: 0 != 1 : /opt/pyenv/versions/3.6.7/bin/python3.6m -m pants --no-pantsrc --pants-workdir=/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/.pants.d/tmp/tmpmckeqkuy.pants.d --kill-nailguns --print-exception-stacktrace=True compile testprojects/src/scala/org/pantsbuild/testproject/javadepsonscalatransitive:java-in-different-package
870                     E   returncode: 1
871                     E   stdout:
872                     E   	
873                     E   	20:37:27 00:00 [main]
874                     E   	               (To run a reporting server: ./pants server)
875                     E   	20:37:28 00:01   [setup]
876                     E   	20:37:28 00:01     [parse]
877                     E   	               Executing tasks in goals: bootstrap -> imports -> unpack-jars -> unpack-wheels -> deferred-sources -> gen -> native-compile -> jvm-platform-validate -> resolve -> resources -> compile
878                     E   	20:37:28 00:01   [bootstrap]
879                     E   	20:37:28 00:01     [substitute-aliased-targets]
880                     E   	20:37:28 00:01     [jar-dependency-management]
881                     E   	20:37:28 00:01     [bootstrap-jvm-tools]
882                     E   	20:37:28 00:01     [provide-tools-jar]
883                     E   	20:37:28 00:01   [imports]
884                     E   	20:37:28 00:01     [ivy-imports]
885                     E   	20:37:28 00:01   [unpack-jars]
886                     E   	20:37:28 00:01     [unpack-jars]
887                     E   	20:37:28 00:01   [unpack-wheels]
888                     E   	20:37:28 00:01     [unpack-wheels]
889                     E   	20:37:28 00:01   [deferred-sources]
890                     E   	20:37:28 00:01     [deferred-sources]
891                     E   	20:37:28 00:01   [gen]
892                     E   	20:37:28 00:01     [antlr-java]
893                     E   	20:37:28 00:01     [antlr-py]
894                     E   	20:37:28 00:01     [jaxb]
895                     E   	20:37:28 00:01     [protoc]
896                     E   	20:37:28 00:01     [ragel]
897                     E   	20:37:28 00:01     [thrift-java]
898                     E   	20:37:28 00:01     [thrift-py]
899                     E   	20:37:28 00:01     [py-thrift-namespace-clash-check]
900                     E   	20:37:28 00:01     [grpcio-prep]
901                     E   	20:37:28 00:01     [grpcio-run]
902                     E   	20:37:28 00:01     [wire]
903                     E   	20:37:28 00:01     [avro-java]
904                     E   	20:37:28 00:01     [go-thrift]
905                     E   	20:37:28 00:01     [go-protobuf]
906                     E   	20:37:28 00:01     [jax-ws]
907                     E   	20:37:28 00:01     [scrooge]
908                     E   	20:37:28 00:01     [thrifty]
909                     E   	20:37:28 00:01   [native-compile]
910                     E   	20:37:28 00:01     [conan-prep]
911                     E   	20:37:28 00:01     [conan-fetch]
912                     E   	20:37:28 00:01     [c-for-ctypes]
913                     E   	20:37:28 00:01     [cpp-for-ctypes]
914                     E   	20:37:29 00:02   [jvm-platform-validate]
915                     E   	20:37:29 00:02     [jvm-platform-validate]
916                     E   	                   Invalidated 4 targets.
917                     E   	20:37:29 00:02   [resolve]
918                     E   	20:37:29 00:02     [ivy]
919                     E   	                   Invalidated 1 target.
920                     E   	20:37:29 00:02       [ivy-resolve]
921                     E   	20:37:29 00:02     [coursier]
922                     E   	20:37:29 00:02     [go]
923                     E   	20:37:29 00:02     [scala-js-compile]
924                     E   	20:37:29 00:02     [scala-js-link]
925                     E   	20:37:29 00:02     [node]
926                     E   	20:37:29 00:02   [resources]
927                     E   	20:37:29 00:02     [prepare]
928                     E   	20:37:29 00:02     [services]
929                     E   	20:37:29 00:02   [compile]
930                     E   	20:37:29 00:02     [node]
931                     E   	20:37:29 00:02     [compile-jvm-prep-command]
932                     E   	20:37:29 00:02       [jvm_prep_command]
933                     E   	20:37:29 00:02     [compile-prep-command]
934                     E   	20:37:29 00:02     [compile]
935                     E   	20:37:29 00:02     [rsc]
936                     E   	                   Invalidated 4 targets.
937                     E   	20:37:29 00:02       [isolation-mixed-pool-bootstrap]
938                     E   	                   [1/7] Rsc-ing 1 mixed source in 1 target (testprojects/src/scala/org/pantsbuild/testproject/javadepsonscalatransitive:scala-2).
939                     E   	                   [2/7] Compiling 1 mixed source in 1 target (testprojects/src/scala/org/pantsbuild/testproject/javadepsonscalatransitive:scala-2).
940                     E   	20:37:30 00:03       [compile]
941                     E   	                     
942                     E   	20:37:30 00:03         [cache]
943                     E   	                     Using cached artifacts for 1 target.
944                     E   	20:37:30 00:03         [ivy-resolve]
945                     E   	                   rsc(testprojects/src/scala/org/pantsbuild/testproject/javadepsonscalatransitive:scala-2) failed: Path for link would overwrite an existing directory: /home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/.pants.d/tmp/tmpmckeqkuy.pants.d/bootstrap/bootstrap-jvm-tools/current in 0.17126083374023438
946                     E   	                   Traceback:
947                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/backend/jvm/tasks/jvm_compile/execution_graph.py", line 287, in worker
948                     E   	                       work()
949                     E   	                   
950                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/backend/jvm/tasks/jvm_compile/execution_graph.py", line 47, in __call__
951                     E   	                       self.fn()
952                     E   	                   
953                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/backend/jvm/tasks/jvm_compile/rsc/rsc_compile.py", line 485, in work_for_vts_rsc
954                     E   	                       self._runtool(distribution, input_digest, ctx, use_youtline)
955                     E   	                   
956                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/backend/jvm/tasks/jvm_compile/rsc/rsc_compile.py", line 901, in _runtool
957                     E   	                       tool_classpath = self._rsc_classpath
958                     E   	                   
959                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/util/memo.py", line 115, in memoize
960                     E   	                       result = func(*args, **kwargs)
961                     E   	                   
962                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/backend/jvm/tasks/jvm_compile/rsc/rsc_compile.py", line 237, in _rsc_classpath
963                     E   	                       return self.tool_classpath('rsc')
964                     E   	                   
965                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/backend/jvm/tasks/jvm_tool_task_mixin.py", line 52, in tool_classpath
966                     E   	                       return self.tool_classpath_from_products(self.context.products, key, scope=self._scope(scope))
967                     E   	                   
968                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/backend/jvm/subsystems/jvm_tool_mixin.py", line 208, in tool_classpath_from_products
969                     E   	                       return [entry.path for entry in cls.tool_classpath_entries_from_products(products, key, scope)]
970                     E   	                   
971                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/backend/jvm/subsystems/jvm_tool_mixin.py", line 226, in tool_classpath_entries_from_products
972                     E   	                       return callback()
973                     E   	                   
974                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/backend/jvm/tasks/bootstrap_jvm_tools.py", line 356, in bootstrap_classpath
975                     E   	                       cache['classpath'] = self._bootstrap_jvm_tool(dep_spec, jvm_tool)
976                     E   	                   
977                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/backend/jvm/tasks/bootstrap_jvm_tools.py", line 345, in _bootstrap_jvm_tool
978                     E   	                       return self._bootstrap_classpath(jvm_tool, targets)
979                     E   	                   
980                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/backend/jvm/tasks/bootstrap_jvm_tools.py", line 246, in _bootstrap_classpath
981                     E   	                       self.resolve(executor=None, targets=targets, classpath_products=classpath_holder)
982                     E   	                   
983                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/backend/jvm/tasks/ivy_task_mixin.py", line 139, in resolve
984                     E   	                       pinned_artifacts=artifact_set))
985                     E   	                   
986                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/backend/jvm/tasks/ivy_task_mixin.py", line 162, in _resolve_subset
987                     E   	                       pinned_artifacts=pinned_artifacts,
988                     E   	                   
989                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/backend/jvm/tasks/ivy_task_mixin.py", line 219, in _ivy_resolve
990                     E   	                       fingerprint_strategy=fingerprint_strategy) as invalidation_check:
991                     E   	                   
992                     E   	                     File "/opt/pyenv/versions/3.6.7/lib/python3.6/contextlib.py", line 81, in __enter__
993                     E   	                       return next(self.gen)
994                     E   	                   
995                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/task/task.py", line 429, in invalidated
996                     E   	                       topological_order)
997                     E   	                   
998                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/task/task.py", line 530, in _do_invalidation_check
999                     E   	                       artifact_write_callback=self.maybe_write_artifact)
1000                     E   	                   
1001                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/invalidation/cache_manager.py", line 288, in __init__
1002                     E   	                       relative_symlink(self._results_dir_prefix, stable_prefix)
1003                     E   	                   
1004                     E   	                     File "/home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/pants/util/dirutil.py", line 487, in relative_symlink
1005                     E   	                       raise ValueError("Path for link would overwrite an existing directory: {}".format(link_path))
1006                     E   	                   
1007                     E   	20:37:30 00:03         [cache]
1008                     E   	                     Using cached artifacts for 1 target.
1009                     E   	20:37:31 00:04         [cache]
1010                     E   	                     Using cached artifacts for 1 target.
1011                     E   	20:37:31 00:04         [cache]
1012                     E   	                     Using cached artifacts for 1 target.
1013                     E   	20:37:31 00:04         [ivy-resolve]
1014                     E   	20:37:31 00:04         [cache]
1015                     E   	                     Using cached artifacts for 1 target.
1016                     E   	20:37:32 00:05         [zinc-subsystem]
1017                     E   	                       [info] Non-compiled module 'compiler-interface' for Scala 2.12.8. Compiling...
1018                     E   	                       [info]   Compilation completed in 14.138s.
1019                     E   	                       
1020                     E   	20:37:48 00:21         [mixed]
1021                     E   	                       [info] Compiling 1 Scala source to /home/travis/build/pantsbuild/pants/.pants.d/pyprep/sources/67668a6ac8c000f9fd15afd73648781e7bf20b33/./.pants.d/tmp/tmpmckeqkuy.pants.d/compile/rsc/c1e3836b60e5/testprojects.src.scala.org.pantsbuild.testproject.javadepsonscalatransitive.scala-2/current/zinc/classes ...
1022                     E   	                       [info] Done compiling.
1023                     E   	                       [info] Compile success at Nov 21, 2019 8:37:55 PM [7.170s]
1024                     E   	                       
1025                     E   	FAILURE: Compilation failure: Failed jobs: rsc(testprojects/src/scala/org/pantsbuild/testproject/javadepsonscalatransitive:scala-2)
1026                     E   	
1027                     E   	
1028                     E   	               Waiting for background workers to finish.
1029                     E   	20:37:55 00:28   [complete]
1030                     E   	               FAILURE
@jsirois
Copy link
Contributor

jsirois commented Nov 25, 2019

Seen again on PR branch.

@jsirois jsirois self-assigned this Mar 24, 2020
jsirois added a commit to jsirois/pants that referenced this issue Mar 25, 2020
@jsirois
Skip all flaky tests with GitHub issues.
ec40520 
This brings our skip count up from 7 python and 2 rust to 25 python and
4 rust, hopefully in the name of stability as outlined in pantsbuild#9386.

Also updates the How to Contribute docs with a pointer to pantsbuild#9386 for
the latest procedure.

Includes flaky tests from:
 pantsbuild#9313 pantsbuild#9312 pantsbuild#8679 pantsbuild#8678 pantsbuild#8520 pantsbuild#8520 pantsbuild#8520 pantsbuild#8405 pantsbuild#8193 pantsbuild#8171 pantsbuild#7836 pantsbuild#7622
 pantsbuild#7573 pantsbuild#7572 pantsbuild#7554 pantsbuild#7547 pantsbuild#7457 pantsbuild#7168 pantsbuild#7149 pantsbuild#6838 pantsbuild#6829 pantsbuild#6787 pantsbuild#6114

[ci skip-jvm-tests]  # No JVM changes made.
@jsirois jsirois mentioned this issue Mar 25, 2020
Merged
jsirois added a commit that referenced this issue Mar 25, 2020
@jsirois
Skip all flaky tests with GitHub issues. (#9391)
f393afd 
This brings our skip count up from 7 python and 2 rust to 25 python and
4 rust, hopefully in the name of stability as outlined in #9386.

Also updates the How to Contribute docs with a pointer to #9386 for
the latest procedure.

Includes flaky tests from:
 #9313 #9312 #8679 #8678 #8520 #8520 #8520 #8405 #8193 #8171 #7836 #7622
 #7573 #7572 #7554 #7547 #7457 #7168 #7149 #6838 #6829 #6787 #6114
@jsirois jsirois removed their assignment Mar 25, 2020
@Eric-Arellano
Copy link
Contributor Author

Test was deleted in Pants 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsirois @Eric-Arellano