Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused error value. #6834

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Nov 29, 2018

Previously we'd see:

   Compiling ui v0.0.1 (/home/jsirois/dev/pantsbuild/pants/src/rust/engine/ui)
warning: unused `std::result::Result` which must be used
   --> ui/src/display.rs:178:5
    |
178 |     self.flush();
    |     ^^^^^^^^^^^^^
    |
    = note: #[warn(unused_must_use)] on by default
    = note: this `Result` may be an `Err` variant, which should be handled

Previously we'd see:
```
   Compiling ui v0.0.1 (/home/jsirois/dev/pantsbuild/pants/src/rust/engine/ui)
warning: unused `std::result::Result` which must be used
   --> ui/src/display.rs:178:5
    |
178 |     self.flush();
    |     ^^^^^^^^^^^^^
    |
    = note: #[warn(unused_must_use)] on by default
    = note: this `Result` may be an `Err` variant, which should be handled
```
@jsirois jsirois requested a review from blorente November 29, 2018 16:02
Copy link
Contributor

@blorente blorente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry I couldn't fix it earlier, but got sidetracked.

@stuhood
Copy link
Member

stuhood commented Nov 29, 2018

Looks like this hit #6829. Sorry about that: will take a look today after making progress on some other stuff.

@jsirois jsirois merged commit 743480b into pantsbuild:master Nov 29, 2018
@jsirois jsirois deleted the rust/ui/propagate_flush_errors branch November 29, 2018 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants