OracleFeeDistributor__ClientBasisPointsShouldBeHigherThan5000

contracts/feeDistributor/BaseFeeDistributor.sol

@@ -75,7 +75,7 @@ abstract contract BaseFeeDistributor is Erc4337Account, OwnableTokenRecoverer, O
     function initialize(
         FeeRecipient calldata _clientConfig,
         FeeRecipient calldata _referrerConfig
-    ) external onlyFactory {
+    ) public virtual onlyFactory {
         if (_clientConfig.recipient == address(0)) {
             revert FeeDistributor__ZeroAddressClient();
         }

contracts/feeDistributor/OracleFeeDistributor.sol

@@ -23,6 +23,9 @@ error OracleFeeDistributor__WaitForEnoughRewardsToWithdraw();
 /// @notice clientOnlyClRewards can only be set once
 error OracleFeeDistributor__CannotResetClientOnlyClRewards();
 
+/// @notice Client basis points should be higher than 5000
+error OracleFeeDistributor__ClientBasisPointsShouldBeHigherThan5000();
+
 /// @title FeeDistributor accepting EL rewards only but splitting them with consideration of CL rewards
 /// @dev CL rewards are received by the client directly since client's address is ETH2 withdrawal credentials
 contract OracleFeeDistributor is BaseFeeDistributor {
@@ -56,6 +59,18 @@ contract OracleFeeDistributor is BaseFeeDistributor {
         i_oracle = IOracle(_oracle);
     }
 
+    /// @inheritdoc IFeeDistributor
+    function initialize(
+        FeeRecipient calldata _clientConfig,
+        FeeRecipient calldata _referrerConfig
+    ) public override {
+        if (_clientConfig.basisPoints <= 5000) {
+            revert OracleFeeDistributor__ClientBasisPointsShouldBeHigherThan5000();
+        }
+
+        super.initialize(_clientConfig, _referrerConfig);
+    }
+
     /// @notice Set clientOnlyClRewards to a new value
     /// @param _clientOnlyClRewards new value of clientOnlyClRewards
     /// @dev may be needed when attaching this FeeDistributor to an existing validator.

test/foundry/Integration.t.sol

@@ -330,7 +330,24 @@ contract Integration is Test {
     function test_OracleFeeDistributor_Creation_Without_Depositor() public {
         console.log("testOracleFeeDistributorCreationWithoutDepositor started");
 
-        address newFeeDistributorAddress = deployOracleFeeDistributorCreationWithoutDepositor();
+        address newFeeDistributorAddress;
+
+        vm.startPrank(operatorAddress);
+        vm.expectRevert(OracleFeeDistributor__ClientBasisPointsShouldBeHigherThan5000.selector);
+        newFeeDistributorAddress = factory.createFeeDistributor(
+            address(oracleFeeDistributorTemplate),
+            FeeRecipient({
+                recipient: clientWcAddress,
+                basisPoints: 4000
+            }),
+            FeeRecipient({
+                recipient: payable(address(0)),
+                basisPoints: 0
+            })
+        );
+        vm.stopPrank();
+
+        newFeeDistributorAddress = deployOracleFeeDistributorCreationWithoutDepositor();
 
         assertEq(newFeeDistributorAddress, oracleFeeDistributorInstanceAddress);
 
@@ -399,13 +416,13 @@ contract Integration is Test {
         newFeeDistributorAddress = factory.createFeeDistributor(
             address(oracleFeeDistributorTemplate),
             FeeRecipient({
-        recipient: clientWcAddress,
-        basisPoints: defaultClientBasisPoints
-        }),
+                recipient: clientWcAddress,
+                basisPoints: defaultClientBasisPoints
+            }),
             FeeRecipient({
-        recipient: payable(address(0)),
-        basisPoints: 0
-        })
+                recipient: payable(address(0)),
+                basisPoints: 0
+            })
         );
 
         vm.stopPrank();