New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit 3 fix #37

Merged

sanbir merged 24 commits into p2p-org:master from sanbir:audit-3-fix

Jul 25, 2023

Member

sanbir commented Jul 19, 2023

Fix

Rewards can be accounted as collateral
The slashed validator’s stake gets split between client, referrer, and service

sanbir added 5 commits

July 10, 2023 15:19


          OracleFeeDistributor__ClientBasisPointsShouldBeHigherThan5000

f89a9d9


          fix 1. Rewards can be accounted as collateral

bbff409


          fix 2. The slashed validator’s stake gets split between client, refer…

04de59a

…rer, and service


          fix 3. Null basis points will lead to the lock of funds

d180529


          fix 4. Client’s collateral can be distributed as rewards

9ddd011

This comment has been minimized.

Sign in to view


          fix 5. Possible ddos of an expiration time

49db303

This comment has been minimized.

Sign in to view


          test_OracleFeeDistributor_withdraw_with_the_same_proof

82053a9

This comment has been minimized.

Sign in to view


          fix H6 test_OracleFeeDistributor_withdraw_after_emergencyEtherRecover…

80a9a4b

…yWithoutOracleData

This comment has been minimized.

Sign in to view


          fix M3 An incorrect distribution of rewards in case of _sendValue revert

05bf2d6

This comment has been minimized.

Sign in to view


          fix M4 s_defaultClientBasisPoints should be restricted

cf26f32

This comment has been minimized.

Sign in to view


          fix M5 Non-existing _feeDistributorInstance can be rejected

29984b6

This comment has been minimized.

Sign in to view


          fix M8 recoverEther function shouldn’t be called with gas restrictions

401457f

This comment has been minimized.

Sign in to view


          fix M11 A failed send to to address in recoverEther leads to over-dis…

54acad9

…tribution to non-failing parties

This comment has been minimized.

Sign in to view


          fix M12 The ServiceRejected status is ignored in the addEth and makeB…

c60cd0c

…eaconDeposit functions of the P2pOrgUnlimitedEthDepositor contract

This comment has been minimized.

Sign in to view


          fix M13 ClientConfig.basisPoints equal to 100% at OracleFeeDistributo…

eec0556

…r could lead to DoS of emergencyEtherRecoveryWithoutOracleData

This comment has been minimized.

Sign in to view


          fix M14 P2pOrgUnlimitedEthDepositor.refundAll() can be blocked for an…

162f0da

…y client

This comment has been minimized.

Sign in to view


          fix L1 A newOwner can be the current owner

3d15938

This comment has been minimized.

Sign in to view


          fix L2 Zero address can be valid

60323bc

This comment has been minimized.

Sign in to view


          fix L3 ERC721 safeTransferFrom is not safe

f039c9a

This comment has been minimized.

Sign in to view


          fix L5 chainId can replace the flag

e26cdf7

This comment has been minimized.

Sign in to view


          fix L6. A missing zero address check

ab0a2a5

This comment has been minimized.

Sign in to view


          fix L7. referrerConfig.basisPoints can be set to 0, even if referrerC…

a1fae62

…onfig.recipient is not address(0)

This comment has been minimized.

Sign in to view


          fix typos

f63f55a

This comment has been minimized.

Sign in to view


          fix typos

51b296d

Member Author

sanbir commented Jul 24, 2023

Fix other issues from the Audit Report

sanbir merged commit ee36451 into p2p-org:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet