Code

Audit 3 fix#37

Code

Merged

sanbir merged 24 commits intop2p-org:masterp2p-org/eth-staking-fee-distributor-contracts:masterfrom sanbir:audit-3-fixsanbir/eth-staking-fee-distributor-contracts:audit-3-fixCopy head branch name to clipboardJul 25, 2023

+566-111

Commits

Commits on Jul 10, 2023

• OracleFeeDistributor__ClientBasisPointsShouldBeHigherThan5000

  sanbir

  committed
  f89a9d9

  Copy full SHA for f89a9d9

Commits on Jul 18, 2023

• fix 1. Rewards can be accounted as collateral

  sanbir

  committed
  bbff409

  Copy full SHA for bbff409

Commits on Jul 19, 2023

• fix 2. The slashed validator’s stake gets split between client, referrer, and service

  sanbir

  committed
  04de59a

  Copy full SHA for 04de59a

• fix 3. Null basis points will lead to the lock of funds

  sanbir

  committed
  d180529

  Copy full SHA for d180529

Commits on Jul 20, 2023

• fix 4. Client’s collateral can be distributed as rewards

  sanbir

  committed
  9ddd011

  Copy full SHA for 9ddd011

• fix 5. Possible ddos of an expiration time

  sanbir

  committed
  49db303

  Copy full SHA for 49db303

Commits on Jul 21, 2023

• test_OracleFeeDistributor_withdraw_with_the_same_proof

  sanbir

  committed
  82053a9

  Copy full SHA for 82053a9

• fix H6 test_OracleFeeDistributor_withdraw_after_emergencyEtherRecoveryWithoutOracleData

  sanbir

  committed
  80a9a4b

  Copy full SHA for 80a9a4b

Commits on Jul 24, 2023

• fix M3 An incorrect distribution of rewards in case of _sendValue revert

  sanbir

  committed
  05bf2d6

  Copy full SHA for 05bf2d6

• fix M4 s_defaultClientBasisPoints should be restricted

  sanbir

  committed
  cf26f32

  Copy full SHA for cf26f32

• fix M5 Non-existing _feeDistributorInstance can be rejected

  sanbir

  committed
  29984b6

  Copy full SHA for 29984b6

• fix M8 recoverEther function shouldn’t be called with gas restrictions

  sanbir

  committed
  401457f

  Copy full SHA for 401457f

• fix M11 A failed send to to address in recoverEther leads to over-distribution to non-failing parties

  sanbir

  committed
  54acad9

  Copy full SHA for 54acad9

• fix M12 The ServiceRejected status is ignored in the addEth and makeBeaconDeposit functions of the P2pOrgUnlimitedEthDepositor contract

  sanbir

  committed
  c60cd0c

  Copy full SHA for c60cd0c

• fix M13 ClientConfig.basisPoints equal to 100% at OracleFeeDistributor could lead to DoS of emergencyEtherRecoveryWithoutOracleData

  sanbir

  committed
  eec0556

  Copy full SHA for eec0556

• fix M14 P2pOrgUnlimitedEthDepositor.refundAll() can be blocked for any client

  sanbir

  committed
  162f0da

  Copy full SHA for 162f0da

• fix L1 A newOwner can be the current owner

  sanbir

  committed
  3d15938

  Copy full SHA for 3d15938

• fix L2 Zero address can be valid

  sanbir

  committed
  60323bc

  Copy full SHA for 60323bc

• fix L3 ERC721 safeTransferFrom is not safe

  sanbir

  committed
  f039c9a

  Copy full SHA for f039c9a

• fix L5 chainId can replace the flag

  sanbir

  committed
  e26cdf7

  Copy full SHA for e26cdf7

• fix L6. A missing zero address check

  sanbir

  committed
  ab0a2a5

  Copy full SHA for ab0a2a5

• fix L7. referrerConfig.basisPoints can be set to 0, even if referrerConfig.recipient is not address(0)

  sanbir

  committed
  a1fae62

  Copy full SHA for a1fae62

• fix typos

  sanbir

  committed
  f63f55a

  Copy full SHA for f63f55a

• fix typos

  sanbir

  committed
  51b296d

  Copy full SHA for 51b296d