Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(transformer): add tests for nested JSX this member expressions in arrow function transform #5413

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Sep 2, 2024

Follow-up after #5356. Handle nested JSX member expressions with this as base object in arrow functions transform (e.g. <this.foo.bar />).

Copy link

graphite-app bot commented Sep 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Sep 2, 2024

CodSpeed Performance Report

Merging #5413 will not alter performance

Comparing 09-02-fix_transformer_handle_nested_jsx_this_member_expression_in_arrow_function_transform (2dc44fa) with main (a1523c6)

Summary

✅ 28 untouched benchmarks

@Dunqing Dunqing changed the base branch from 09-02-perf_transformer_remove_an_allocation_from_arrow_functions_transform to graphite-base/5413 September 3, 2024 01:07
@Dunqing Dunqing force-pushed the 09-02-fix_transformer_handle_nested_jsx_this_member_expression_in_arrow_function_transform branch from a4ff7cb to 0d24ea7 Compare September 3, 2024 01:10
@Dunqing Dunqing changed the base branch from graphite-base/5413 to main September 3, 2024 01:11
@Dunqing Dunqing force-pushed the 09-02-fix_transformer_handle_nested_jsx_this_member_expression_in_arrow_function_transform branch from 0d24ea7 to 2dc44fa Compare September 3, 2024 01:11
@overlookmotel overlookmotel force-pushed the 09-02-fix_transformer_handle_nested_jsx_this_member_expression_in_arrow_function_transform branch from 2dc44fa to 791d8ee Compare September 3, 2024 14:42
@overlookmotel overlookmotel changed the title fix(transformer): handle nested JSX this member expression in arrow function transform test(transformer): add tests for nested JSX this member expressions in arrow function transform Sep 3, 2024
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Sep 3, 2024 — with Graphite App
Copy link

graphite-app bot commented Sep 3, 2024

Merge activity

  • Sep 3, 10:49 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 3, 10:59 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 3, 11:05 AM EDT: Dunqing added this pull request to the Graphite merge queue.
  • Sep 3, 11:09 AM EDT: Dunqing merged this pull request with the Graphite merge queue.

… in arrow function transform (#5413)

Follow-up after #5356. Handle nested JSX member expressions with `this` as base object in arrow functions transform (e.g. `<this.foo.bar />`).
@Dunqing Dunqing force-pushed the 09-02-fix_transformer_handle_nested_jsx_this_member_expression_in_arrow_function_transform branch from 791d8ee to b9ef357 Compare September 3, 2024 15:06
@graphite-app graphite-app bot merged commit b9ef357 into main Sep 3, 2024
15 checks passed
@graphite-app graphite-app bot deleted the 09-02-fix_transformer_handle_nested_jsx_this_member_expression_in_arrow_function_transform branch September 3, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants