Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ast)!: remove get_object_identifier and get_object_identifier_mut #5357

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Aug 30, 2024

These two methods are no longer needed

@github-actions github-actions bot added the A-ast Area - AST label Aug 30, 2024
@Dunqing Dunqing changed the title chore(ast): remove get_object_identifier and get_object_identifier_mut chore(ast): remove get_object_identifier and get_object_identifier_mut Aug 30, 2024
Copy link

graphite-app bot commented Aug 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Aug 30, 2024

CodSpeed Performance Report

Merging #5357 will not alter performance

Comparing 08-31-chore_ast_remove_get_object_identifier_and_get_object_identifier_mut (a72cc96) with main (94ff94c)

Summary

✅ 28 untouched benchmarks

@Dunqing Dunqing changed the title chore(ast): remove get_object_identifier and get_object_identifier_mut chore(ast)!: remove get_object_identifier and get_object_identifier_mut Aug 30, 2024
@Dunqing Dunqing force-pushed the 08-31-fix_transformer_arrow-functions_reaches_unreachable_when_this.foo_is_inside_an_arrow_function branch from 2c0be6e to e0ce648 Compare September 1, 2024 02:47
@Dunqing Dunqing force-pushed the 08-31-chore_ast_remove_get_object_identifier_and_get_object_identifier_mut branch from 9e10542 to 012af67 Compare September 1, 2024 02:47
@overlookmotel overlookmotel changed the base branch from 08-31-fix_transformer_arrow-functions_reaches_unreachable_when_this.foo_is_inside_an_arrow_function to graphite-base/5357 September 2, 2024 18:06
@overlookmotel overlookmotel force-pushed the 08-31-chore_ast_remove_get_object_identifier_and_get_object_identifier_mut branch from 012af67 to e7cbc77 Compare September 2, 2024 18:09
@overlookmotel overlookmotel changed the base branch from graphite-base/5357 to main September 2, 2024 18:10
@overlookmotel overlookmotel force-pushed the 08-31-chore_ast_remove_get_object_identifier_and_get_object_identifier_mut branch from e7cbc77 to 7175ace Compare September 2, 2024 18:10
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 2, 2024
Copy link

graphite-app bot commented Sep 2, 2024

Merge activity

  • Sep 2, 2:25 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 2, 2:25 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 2, 2:29 PM EDT: overlookmotel merged this pull request with the Graphite merge queue.

…r_mut` (#5357)

These two methods are no longer needed
@overlookmotel overlookmotel force-pushed the 08-31-chore_ast_remove_get_object_identifier_and_get_object_identifier_mut branch from 7175ace to a72cc96 Compare September 2, 2024 18:26
@graphite-app graphite-app bot merged commit a72cc96 into main Sep 2, 2024
23 checks passed
@graphite-app graphite-app bot deleted the 08-31-chore_ast_remove_get_object_identifier_and_get_object_identifier_mut branch September 2, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants