Revert changes to enter_jsx_member_expression_object

oxc-project · Sep 3, 2024 · 791d8ee · 791d8ee
1 parent 6f62a31
commit 791d8ee
Showing 1 changed file with 7 additions and 17 deletions.
diff --git a/crates/oxc_transformer/src/es2015/arrow_functions.rs b/crates/oxc_transformer/src/es2015/arrow_functions.rs
@@ -149,30 +149,20 @@ impl<'a> Traverse<'a> for ArrowFunctions<'a> {
     /// Change <this.foo></this.foo> to <_this.foo></_this.foo>, and mark it as found
     fn enter_jsx_member_expression_object(
         &mut self,
-        object: &mut JSXMemberExpressionObject<'a>,
+        node: &mut JSXMemberExpressionObject<'a>,
         ctx: &mut TraverseCtx<'a>,
     ) {
         if !self.is_inside_arrow_function() {
             return;
         }
 
-        let mut object = object;
-        let ident = loop {
-            match object {
-                JSXMemberExpressionObject::IdentifierReference(ident) => {
-                    if ident.name == "this" {
-                        break ident;
-                    }
-                    return;
-                }
-                JSXMemberExpressionObject::MemberExpression(member_expr) => {
-                    object = &mut member_expr.object;
-                }
+        if let JSXMemberExpressionObject::IdentifierReference(ident) = node {
+            if ident.name == "this" {
+                let new_ident = self.get_this_name(ctx).create_read_reference(ctx);
+                ident.name = new_ident.name;
+                ident.reference_id = new_ident.reference_id;
             }
-        };
-        let new_ident = self.get_this_name(ctx).create_read_reference(ctx);
-        ident.name = new_ident.name;
-        ident.reference_id = new_ident.reference_id;
+        }
     }
 
     fn enter_expression(&mut self, expr: &mut Expression<'a>, _ctx: &mut TraverseCtx<'a>) {