Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm E2E in Openshift API-CI #1508

Merged
merged 7 commits into from
Jul 15, 2019
Merged

Helm E2E in Openshift API-CI #1508

merged 7 commits into from
Jul 15, 2019

Conversation

AlexNPavel
Copy link
Contributor

Testing helm e2e in openshift-ci

Based on #1384

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 31, 2019
@AlexNPavel AlexNPavel changed the title [WIP] Testing E2E ansible DO NOT MERGE [WIP] Testing E2E helm DO NOT MERGE May 31, 2019
@AlexNPavel AlexNPavel force-pushed the e2e-prow-helm branch 5 times, most recently from e1610cb to c327013 Compare June 3, 2019 18:00
@AlexNPavel AlexNPavel changed the title [WIP] Testing E2E helm DO NOT MERGE [WIP] Helm E2E in Openshift API-CI Jun 3, 2019
@AlexNPavel AlexNPavel force-pushed the e2e-prow-helm branch 9 times, most recently from 7272c9b to 8838032 Compare June 10, 2019 23:13
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2019
@AlexNPavel AlexNPavel force-pushed the e2e-prow-helm branch 2 times, most recently from b22173e to 3115ca1 Compare June 28, 2019 23:13
@AlexNPavel AlexNPavel changed the title [WIP] Helm E2E in Openshift API-CI Helm E2E in Openshift API-CI Jun 28, 2019
@AlexNPavel AlexNPavel marked this pull request as ready for review June 28, 2019 23:14
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2019
@AlexNPavel
Copy link
Contributor Author

/cc @joelanford @hasbro17 @estroz

This is ready for review. It is pretty much the same as the ansible PR but is based on the existing helm tests and also has a change in cmd/.../new to add a new flag that disables role generation in helm, as that requires a k8s cluster, which we don't have at generation time in openshift-ci (we only disable it during the image build; role generation is enabled during the e2e test)

joelanford
joelanford previously requested changes Jun 29, 2019
View reviewed changes
ci/tests/e2e-helm-scaffold-hybrid.sh Outdated Show resolved Hide resolved
ci/tests/e2e-helm.sh Outdated Show resolved Hide resolved
@AlexNPavel AlexNPavel mentioned this pull request Jul 8, 2019
Merged
@AlexNPavel
Copy link
Contributor Author

Corresponding openshift/release PR for this PR: openshift/release#4313

hasbro17
hasbro17 approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shawn-hurley
shawn-hurley approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@shawn-hurley shawn-hurley dismissed joelanford’s stale review July 15, 2019 20:41

Joe is on vacation

@AlexNPavel AlexNPavel merged commit 936584d into operator-framework:master Jul 15, 2019
@AlexNPavel AlexNPavel deleted the e2e-prow-helm branch July 15, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawn-hurley shawn-hurley shawn-hurley approved these changes

@hasbro17 hasbro17 hasbro17 approved these changes

@joelanford joelanford joelanford left review comments

@estroz estroz Awaiting requested review from estroz

@lilic lilic Awaiting requested review from lilic

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexNPavel @joelanford @shawn-hurley @hasbro17 @openshift-ci-robot