Golang E2E in Openshift API-CI #1384
Conversation
AlexNPavel
added
the
area/testing
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/L
AlexNPavel
force-pushed
the
e2e-prow
branch
25 times, most recently
from
cb1f293 to
dedea01
Compare
|
This has been fully retested and is ready to be reviewed again. Corresponding |
| @@ -47,7 +47,7 @@ func Become(ctx context.Context, lockName string) error { | |||
|
|
|||
| ns, err := k8sutil.GetOperatorNamespace() | |||
| if err != nil { | |||
| if err == k8sutil.ErrNoNamespace { | |||
| if err == k8sutil.ErrNoNamespace || err == k8sutil.ErrRunLocal { | |||
There was a problem hiding this comment.
One question: At this point is there ever a case where err == k8sutil.ErrNoNamespace and err != k8sutil.ErrRunLocal?
Looking at the errors returned by cluster specific functions such as initOperatorService() and GetOperatorNamespace(), GetOperatorName() it seems they will all return ErrRunLocal if running locally.
There was a problem hiding this comment.
If a user is using our commands, ErrNoNamespace probably shouldn't be hit since we manually force the run mode. I do assume it's possible if a user manually runs it themselves with go run cmd/manager/main.go.
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
New changes are detected. LGTM label has been removed. |
|
/retest |
1 similar comment
|
/retest |
This is currently a WIP for a POC to allow us to run the entire golang E2E suite in openshift-ci with the exception of the image building part of
operator-sdk build, which can be replaced with comprehensive unit tests.