Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator-sdk: add helm e2e tests to ci #4313

Merged
merged 1 commit into from
Jul 15, 2019
Merged

operator-sdk: add helm e2e tests to ci #4313

merged 1 commit into from
Jul 15, 2019

Conversation

AlexNPavel
Copy link
Contributor

Add e2e testing support for operator-sdk generated helm operators. Depends on operator-framework/operator-sdk#1508

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 8, 2019
@AlexNPavel AlexNPavel mentioned this pull request Jul 8, 2019
Merged
@AlexNPavel
Copy link
Contributor Author

/retest

@AlexNPavel
Copy link
Contributor Author

/cc @hasbro17 @shawn-hurley @estroz

estroz
estroz approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexNPavel, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 676fdf7 into openshift:master Jul 15, 2019
@openshift-ci-robot
Copy link
Contributor

@AlexNPavel: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key operator-framework-operator-sdk-master.yaml using file ci-operator/config/operator-framework/operator-sdk/operator-framework-operator-sdk-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key operator-framework-operator-sdk-master.yaml using file ci-operator/config/operator-framework/operator-sdk/operator-framework-operator-sdk-master.yaml
  • job-config-master-presubmits configmap in namespace ci using the following files:
    • key operator-framework-operator-sdk-master-presubmits.yaml using file ci-operator/jobs/operator-framework/operator-sdk/operator-framework-operator-sdk-master-presubmits.yaml

In response to this:

Add e2e testing support for operator-sdk generated helm operators. Depends on operator-framework/operator-sdk#1508

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlexNPavel AlexNPavel deleted the osdk-e2e-helm branch July 15, 2019 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estroz estroz estroz approved these changes

@fabianvf fabianvf Awaiting requested review from fabianvf

@lilic lilic Awaiting requested review from lilic

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexNPavel @openshift-ci-robot @estroz @openshift-merge-robot