NE-1808: Bump k8s.io, openshift, controller-runtime modules and golang #143

alebedev87 · 2024-12-11T23:39:02Z

Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.- Bumped golang to 1.22:
- Update go.mod
- Update Dockerfiles

Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.
Bumped controller-runtime to 0.18.5:
- Manager's Port option removed, now using dedicated webhook server field (⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422).
- Manager's MetricsBindAddress option removed, now using dedicated metrics server field (⚠ Introduce Metrics Options struct & secure metrics serving kubernetes-sigs/controller-runtime#2407).
- Cache's Namespaces option replaced by DefaultNamespaces (⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421).
Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.
Regenerated CRD and bundle manifests using make bundle command.
Bumped kustomize to v5 to fix a conflict caused by k8s.io bumps:
- kyaml unable to use the bumped github.com/google/gnostic-models/openapiv2 package.
Removed TypeMeta from expected deployment object when it's compared to structured one retrieved from fake client (⚠️ Fakeclient: Only set TypeMeta for unstructured kubernetes-sigs/controller-runtime#2633).
Migrated infrastructure CRD retrieval to the new package zz_generated.crd-manifests:
- Updated infrastructure CRD for unit tests using make update-vendored-crds command.
Updated envtest setup to use the downstream index.
- Infrastructure CRD uses CEL functions backported from newer k8s API.
- Upstream envtest is not ready to use newer CEL function.
- Bumped setup-envtest to be able to use --index flag.

Commands to reproduce the bump:

go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get github.com/openshift/[email protected]
go get sigs.k8s.io/[email protected]
go get sigs.k8s.io/kustomize/kustomize/[email protected]
o get sigs.k8s.io/aws-load-balancer-controller@f39ae43121c3f4de0129dda483c10b17a687491d
go get github.com/openshift/api/config/v1/[email protected]
go get sigs.k8s.io/controller-runtime/tools/setup-envtest@75a38d2123d4696d24d8d3c6b2966e7a34442653
go mod tidy
go mod vendor
make bundle
make update-vendored-crds

openshift-ci-robot · 2024-12-11T23:39:06Z

@alebedev87: This pull request references NE-1808 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Bumped golang to 1.22:

Update go.mod

Update Dockerfiles

Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.

Bumped controller-runtime to 0.18.5:

Manager's Port option removed, now using dedicated webhook server field (⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422).

Manager's MetricsBindAddress option removed, now using dedicated metrics server field (⚠ Introduce Metrics Options struct & secure metrics serving kubernetes-sigs/controller-runtime#2407).

Cache's Namespaces option replaced by DefaultNamespaces (⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421).

Regenerated CRD and bundle manifests using make bundle command.

Bumped kustomize to v5 to fix a conflict caused by k8s.io bumps:

kyaml unable to use the bumped github.com/google/gnostic-models/openapiv2 package.

Removed TypeMeta from expected deployment object when it's compared to structured one retrieved from fake client (⚠️ Fakeclient: Only set TypeMeta for unstructured kubernetes-sigs/controller-runtime#2633).

Commands to reproduce the bump:
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get github.com/openshift/[email protected]
go get sigs.k8s.io/[email protected]
go get sigs.k8s.io/kustomize/kustomize/[email protected]
go mod tidy
go mod vendor
make bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2024-12-12T10:46:09Z

/test e2e-aws-proxy-operator

AWS jobs run slow recently (a rush before Christmas?).

lihongan · 2024-12-13T01:06:37Z

/retest

Step e2e-aws-proxy-operator-optional-operators-subscribe failed after 33m0s
FAIL: TestAWSLoadBalancerControllerWithWAFv2 (1020.22s)

lihongan · 2024-12-13T06:25:49Z

.ci-operator.yaml

@@ -1,4 +1,4 @@
 build_root_image:
  name: release
  namespace: openshift
-  tag: rhel-8-release-golang-1.19-openshift-4.12
+  tag: rhel-8-release-golang-1.22-openshift-4.17


can we change to rhel-9-release ?`

RHEL9 migration is something we need to do, not only in this repository. Unfortunately I don't think I'll have enough time to do it for this release (before Christmas break). So, we need to file a bug for RHEL9 migration similar to what we did for the externaldns.

OK. then other look good.
@ShudiLi could you please help file a bug.

@lihongan Filed https://issues.redhat.com/browse/OCPBUGS-46442, thanks.

alebedev87 · 2024-12-16T15:50:33Z

Bumped aws-load-balancer-controller module according to the remark from PR#139.

alebedev87 · 2024-12-16T16:47:58Z

OutOfMemoryKilled

/retest

openshift-ci-robot · 2024-12-16T17:15:22Z

@alebedev87: This pull request references NE-1808 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Bumped golang to 1.22:

Update go.mod

Update Dockerfiles

Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.

Bumped controller-runtime to 0.18.5:

Manager's Port option removed, now using dedicated webhook server field (⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422).

Manager's MetricsBindAddress option removed, now using dedicated metrics server field (⚠ Introduce Metrics Options struct & secure metrics serving kubernetes-sigs/controller-runtime#2407).

Cache's Namespaces option replaced by DefaultNamespaces (⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421).

Regenerated CRD and bundle manifests using make bundle command.

Bumped kustomize to v5 to fix a conflict caused by k8s.io bumps:

kyaml unable to use the bumped github.com/google/gnostic-models/openapiv2 package.

Removed TypeMeta from expected deployment object when it's compared to structured one retrieved from fake client (⚠️ Fakeclient: Only set TypeMeta for unstructured kubernetes-sigs/controller-runtime#2633).

Commands to reproduce the bump:
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get github.com/openshift/[email protected]
go get sigs.k8s.io/[email protected]
go get sigs.k8s.io/kustomize/kustomize/[email protected]
o get sigs.k8s.io/aws-load-balancer-controller@f39ae43121c3f4de0129dda483c10b17a687491d
go get github.com/openshift/api/config/v1/[email protected]
go mod tidy
go mod vendor
make bundle
make update-vendored-crds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-12-16T17:19:22Z

@alebedev87: This pull request references NE-1808 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.- Bumped golang to 1.22:

Update go.mod

Update Dockerfiles

Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.

Bumped controller-runtime to 0.18.5:

Manager's Port option removed, now using dedicated webhook server field (⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422).

Manager's MetricsBindAddress option removed, now using dedicated metrics server field (⚠ Introduce Metrics Options struct & secure metrics serving kubernetes-sigs/controller-runtime#2407).

Cache's Namespaces option replaced by DefaultNamespaces (⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421).

Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.

Regenerated CRD and bundle manifests using make bundle command.

Bumped kustomize to v5 to fix a conflict caused by k8s.io bumps:

kyaml unable to use the bumped github.com/google/gnostic-models/openapiv2 package.

Removed TypeMeta from expected deployment object when it's compared to structured one retrieved from fake client (⚠️ Fakeclient: Only set TypeMeta for unstructured kubernetes-sigs/controller-runtime#2633).

Migrated the infrastructure CRD retrieval to the new package zz_generated.crd-manifests.

Updated infrastructure CRD used in the unit test using make update-vendored-crds command.

Commands to reproduce the bump:
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get github.com/openshift/[email protected]
go get sigs.k8s.io/[email protected]
go get sigs.k8s.io/kustomize/kustomize/[email protected]
o get sigs.k8s.io/aws-load-balancer-controller@f39ae43121c3f4de0129dda483c10b17a687491d
go get github.com/openshift/api/config/v1/[email protected]
go mod tidy
go mod vendor
make bundle
make update-vendored-crds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-12-16T17:21:10Z

@alebedev87: This pull request references NE-1808 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.- Bumped golang to 1.22:

Update go.mod

Update Dockerfiles

Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.

Bumped controller-runtime to 0.18.5:

Manager's Port option removed, now using dedicated webhook server field (⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422).

Manager's MetricsBindAddress option removed, now using dedicated metrics server field (⚠ Introduce Metrics Options struct & secure metrics serving kubernetes-sigs/controller-runtime#2407).

Cache's Namespaces option replaced by DefaultNamespaces (⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421).

Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.

Regenerated CRD and bundle manifests using make bundle command.

Bumped kustomize to v5 to fix a conflict caused by k8s.io bumps:

kyaml unable to use the bumped github.com/google/gnostic-models/openapiv2 package.

Removed TypeMeta from expected deployment object when it's compared to structured one retrieved from fake client (⚠️ Fakeclient: Only set TypeMeta for unstructured kubernetes-sigs/controller-runtime#2633).

Migrated infrastructure CRD retrieval to the new package zz_generated.crd-manifests:

Updated infrastructure CRD for unit tests using make update-vendored-crds command.

Commands to reproduce the bump:
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get github.com/openshift/[email protected]
go get sigs.k8s.io/[email protected]
go get sigs.k8s.io/kustomize/kustomize/[email protected]
o get sigs.k8s.io/aws-load-balancer-controller@f39ae43121c3f4de0129dda483c10b17a687491d
go get github.com/openshift/api/config/v1/[email protected]
go mod tidy
go mod vendor
make bundle
make update-vendored-crds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2024-12-16T17:22:04Z

Migrated infrastructure CRD retrieval to the new package zz_generated.crd-manifests after the merge of #137.

alebedev87 · 2024-12-16T19:55:30Z

OutOfMemoryKilled

/retest

ShudiLi · 2024-12-17T05:56:29Z

tested it with 4.18.0-0.ci.test-2024-12-17-024008-ci-ln-gi4bdmb-latest

1.
 % oc get clusterversion
NAME      VERSION                                                   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.18.0-0.ci.test-2024-12-17-024008-ci-ln-gi4bdmb-latest   True        False         106m    Cluster version is 4.18.0-0.ci.test-2024-12-17-024008-ci-ln-gi4bdmb-latest

2.
% oc -n aws-load-balancer-operator  get pods                                                                    
NAME                                                              READY   STATUS      RESTARTS   AGE
792699d494754ea9f0ee4383a1ee7c9d515dd5720cf9b35fb9b2c31ecazbzcm   0/1     Completed   0          94m
aws-load-balancer-controller-cluster-5bb5f9fd9b-gk8bn             1/1     Running     0          49m
aws-load-balancer-operator-controller-manager-b88dc9679-tcb42     2/2     Running     0          94m
baeb04a3c4614c05dbbdbcc1844865253c12838d5adf8c2f896e79f14a1bbaf   1/1     Running     0          94m

3.
% go version -m manager 
manager: go1.22.7 (Red Hat 1.22.7-1.module+el8.10.0+22325+dc584f75)
	path	command-line-arguments
	dep	github.com/aws/aws-sdk-go-v2	v1.16.2	
	dep	github.com/aws/aws-sdk-go-v2/config	v1.13.1	
	dep	github.com/aws/aws-sdk-go-v2/credentials	v1.8.0	
	dep	github.com/aws/aws-sdk-go-v2/feature/ec2/imds	v1.10.0	
	dep	github.com/aws/aws-sdk-go-v2/internal/configsources	v1.1.9	
	dep	github.com/aws/aws-sdk-go-v2/internal/endpoints/v2	v2.4.3	
	dep	github.com/aws/aws-sdk-go-v2/internal/ini	v1.3.5	
	dep	github.com/aws/aws-sdk-go-v2/service/ec2	v1.29.0	
	dep	github.com/aws/aws-sdk-go-v2/service/internal/presigned-url	v1.7.0	
	dep	github.com/aws/aws-sdk-go-v2/service/sso	v1.9.0	
	dep	github.com/aws/aws-sdk-go-v2/service/sts	v1.14.0	
	dep	github.com/aws/smithy-go	v1.11.2	
	dep	github.com/beorn7/perks	v1.0.1	
	dep	github.com/cespare/xxhash/v2	v2.2.0	
	dep	github.com/davecgh/go-spew	v1.1.2-0.20180830191138-d8f796af33cc	
	dep	github.com/emicklei/go-restful/v3	v3.11.0	
	dep	github.com/evanphx/json-patch/v5	v5.9.0	
	dep	github.com/fsnotify/fsnotify	v1.7.0	
	dep	github.com/go-logr/logr	v1.4.1	
	dep	github.com/go-logr/zapr	v1.3.0	
	dep	github.com/go-openapi/jsonpointer	v0.19.6	
	dep	github.com/go-openapi/jsonreference	v0.20.2	
	dep	github.com/go-openapi/swag	v0.22.4	
	dep	github.com/gogo/protobuf	v1.3.2	
	dep	github.com/golang/groupcache	v0.0.0-20210331224755-41bb18bfe9da	
	dep	github.com/golang/protobuf	v1.5.4	
	dep	github.com/google/gnostic-models	v0.6.8	
	dep	github.com/google/go-cmp	v0.6.0	
	dep	github.com/google/gofuzz	v1.2.0	
	dep	github.com/google/uuid	v1.3.1	
	dep	github.com/imdario/mergo	v0.3.13	
	dep	github.com/jmespath/go-jmespath	v0.4.0	
	dep	github.com/josharian/intern	v1.0.0	
	dep	github.com/json-iterator/go	v1.1.12	
	dep	github.com/mailru/easyjson	v0.7.7	
	dep	github.com/matttproud/golang_protobuf_extensions	v1.0.4	
	dep	github.com/modern-go/concurrent	v0.0.0-20180306012644-bacd9c7ef1dd	
	dep	github.com/modern-go/reflect2	v1.0.2	
	dep	github.com/munnerz/goautoneg	v0.0.0-20191010083416-a7dc8b61c822	
	dep	github.com/openshift/api	v0.0.0-20240812094746-86145edb40cf	
	dep	github.com/openshift/aws-load-balancer-operator	(devel)	
	dep	github.com/openshift/cloud-credential-operator	v0.0.0-20230816031419-2c3298b1bb3a	
	dep	github.com/operator-framework/operator-lib	v0.11.0	
	dep	github.com/pkg/errors	v0.9.1	
	dep	github.com/prometheus/client_golang	v1.16.0	
	dep	github.com/prometheus/client_model	v0.4.0	
	dep	github.com/prometheus/common	v0.44.0	
	dep	github.com/prometheus/procfs	v0.12.0	
	dep	github.com/spf13/pflag	v1.0.5	
	dep	go.uber.org/multierr	v1.11.0	
	dep	go.uber.org/zap	v1.26.0	
	dep	golang.org/x/exp	v0.0.0-20220722155223-a9213eeb770e	
	dep	golang.org/x/net	v0.23.0	
	dep	golang.org/x/oauth2	v0.12.0	
	dep	golang.org/x/sys	v0.18.0	
	dep	golang.org/x/term	v0.18.0	
	dep	golang.org/x/text	v0.14.0	
	dep	golang.org/x/time	v0.3.0	
	dep	gomodules.xyz/jsonpatch/v2	v2.4.0	
	dep	google.golang.org/protobuf	v1.33.0	
	dep	gopkg.in/inf.v0	v0.9.1	
	dep	gopkg.in/yaml.v2	v2.4.0	
	dep	gopkg.in/yaml.v3	v3.0.1	
	dep	k8s.io/api	v0.30.3	
	dep	k8s.io/apiextensions-apiserver	v0.30.3	
	dep	k8s.io/apimachinery	v0.30.3	
	dep	k8s.io/client-go	v0.30.3	
	dep	k8s.io/klog/v2	v2.120.1	
	dep	k8s.io/kube-openapi	v0.0.0-20240228011516-70dd3763d340	
	dep	k8s.io/utils	v0.0.0-20240502163921-fe8a2dddb1d0	
	dep	sigs.k8s.io/controller-runtime	v0.18.5	
	dep	sigs.k8s.io/json	v0.0.0-20221116044647-bc3834ca7abd	
	dep	sigs.k8s.io/structured-merge-diff/v4	v4.4.1	
	dep	sigs.k8s.io/yaml	v1.4.0	
	build	-buildmode=exe
	build	-compiler=gc
	build	-tags=strictfipsruntime
	build	CGO_ENABLED=1
	build	CGO_CFLAGS=
	build	CGO_CPPFLAGS=
	build	CGO_CXXFLAGS=
	build	CGO_LDFLAGS=
	build	GOARCH=amd64
	build	GOOS=linux
	build	GOAMD64=v1

4.
%oc get crd  infrastructures.config.openshift.io -oyaml

5. created the ingress and then curl the ALB with the specified host

ShudiLi · 2024-12-17T05:57:31Z

/label qe-approved
thanks

openshift-ci-robot · 2024-12-17T05:57:38Z

@alebedev87: This pull request references NE-1808 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.- Bumped golang to 1.22:

Update go.mod

Update Dockerfiles

Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.

Bumped controller-runtime to 0.18.5:

Manager's Port option removed, now using dedicated webhook server field (⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422).

Manager's MetricsBindAddress option removed, now using dedicated metrics server field (⚠ Introduce Metrics Options struct & secure metrics serving kubernetes-sigs/controller-runtime#2407).

Cache's Namespaces option replaced by DefaultNamespaces (⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421).

Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.

Regenerated CRD and bundle manifests using make bundle command.

Bumped kustomize to v5 to fix a conflict caused by k8s.io bumps:

kyaml unable to use the bumped github.com/google/gnostic-models/openapiv2 package.

Removed TypeMeta from expected deployment object when it's compared to structured one retrieved from fake client (⚠️ Fakeclient: Only set TypeMeta for unstructured kubernetes-sigs/controller-runtime#2633).

Migrated infrastructure CRD retrieval to the new package zz_generated.crd-manifests:

Updated infrastructure CRD for unit tests using make update-vendored-crds command.

Commands to reproduce the bump:
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get github.com/openshift/[email protected]
go get sigs.k8s.io/[email protected]
go get sigs.k8s.io/kustomize/kustomize/[email protected]
o get sigs.k8s.io/aws-load-balancer-controller@f39ae43121c3f4de0129dda483c10b17a687491d
go get github.com/openshift/api/config/v1/[email protected]
go mod tidy
go mod vendor
make bundle
make update-vendored-crds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2024-12-17T06:26:11Z

/retest

- Bumped golang to 1.22: - Update go.mod - Update Dockerfiles - Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf. - Bumped controller-runtime to 0.18.5: - Manager's `Port` option removed, now using dedicated webhook server field (kubernetes-sigs/controller-runtime#2422). - Manager's `MetricsBindAddress` option removed, now using dedicated metrics server field (kubernetes-sigs/controller-runtime#2407). - Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421). - Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests. - Regenerated CRD and bundle manifests using `make bundle` command. - Bumped `kustomize` to v5 to fix a conflict caused by k8s.io bumps: - `kyaml` unable to use the bumped `github.com/google/gnostic-models/openapiv2` package. - Removed `TypeMeta` from expected deployment object when it's compared to structured one retrieved from fake client (kubernetes-sigs/controller-runtime#2633). - Migrated infrastructure CRD retrieval to the new package `zz_generated.crd-manifests`: - Updated infrastructure CRD for unit tests using `make update-vendored-crds` command. - Updated envtest setup to use the downstream index. - Infrastructure CRD uses CEL functions backported from newer k8s API. - Upstream `envtest` is not ready to use newer CEL function. - Bumped `setup-envtest` to be able to use `--index` flag.

alebedev87 · 2024-12-17T15:41:27Z

To fix the unit test:

Updated envtest setup to use the downstream index.
- Infrastructure CRD uses CEL functions backported from newer k8s API.
- Upstream envtest is not ready to use newer CEL function.
- Bumped setup-envtest to be able to use --index flag.

openshift-ci-robot · 2024-12-17T15:42:37Z

@alebedev87: This pull request references NE-1808 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.- Bumped golang to 1.22:

Update go.mod

Update Dockerfiles

Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.

Bumped controller-runtime to 0.18.5:

Manager's Port option removed, now using dedicated webhook server field (⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422).

Manager's MetricsBindAddress option removed, now using dedicated metrics server field (⚠ Introduce Metrics Options struct & secure metrics serving kubernetes-sigs/controller-runtime#2407).

Cache's Namespaces option replaced by DefaultNamespaces (⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421).

Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.

Regenerated CRD and bundle manifests using make bundle command.

Bumped kustomize to v5 to fix a conflict caused by k8s.io bumps:

kyaml unable to use the bumped github.com/google/gnostic-models/openapiv2 package.

Removed TypeMeta from expected deployment object when it's compared to structured one retrieved from fake client (⚠️ Fakeclient: Only set TypeMeta for unstructured kubernetes-sigs/controller-runtime#2633).

Migrated infrastructure CRD retrieval to the new package zz_generated.crd-manifests:

Updated infrastructure CRD for unit tests using make update-vendored-crds command.

Updated envtest setup to use the downstream index.
-Infrastructure CRD uses CEL functions backported from newer k8s API.

Upstream envtest is not ready to use newer CEL function.

Bumped setup-envtest to be able to use --index flag.

Commands to reproduce the bump:
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get github.com/openshift/[email protected]
go get sigs.k8s.io/[email protected]
go get sigs.k8s.io/kustomize/kustomize/[email protected]
o get sigs.k8s.io/aws-load-balancer-controller@f39ae43121c3f4de0129dda483c10b17a687491d
go get github.com/openshift/api/config/v1/[email protected]
go get sigs.k8s.io/controller-runtime/tools/setup-envtest@75a38d2123d4696d24d8d3c6b2966e7a34442653
go mod tidy
go mod vendor
make bundle
make update-vendored-crds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-12-17T15:43:04Z

@alebedev87: This pull request references NE-1808 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.- Bumped golang to 1.22:

Update go.mod

Update Dockerfiles

Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.

Bumped controller-runtime to 0.18.5:

Manager's Port option removed, now using dedicated webhook server field (⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422).

Manager's MetricsBindAddress option removed, now using dedicated metrics server field (⚠ Introduce Metrics Options struct & secure metrics serving kubernetes-sigs/controller-runtime#2407).

Cache's Namespaces option replaced by DefaultNamespaces (⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421).

Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.

Regenerated CRD and bundle manifests using make bundle command.

Bumped kustomize to v5 to fix a conflict caused by k8s.io bumps:

kyaml unable to use the bumped github.com/google/gnostic-models/openapiv2 package.

Removed TypeMeta from expected deployment object when it's compared to structured one retrieved from fake client (⚠️ Fakeclient: Only set TypeMeta for unstructured kubernetes-sigs/controller-runtime#2633).

Migrated infrastructure CRD retrieval to the new package zz_generated.crd-manifests:

Updated infrastructure CRD for unit tests using make update-vendored-crds command.

Updated envtest setup to use the downstream index.

Infrastructure CRD uses CEL functions backported from newer k8s API.

Upstream envtest is not ready to use newer CEL function.

Bumped setup-envtest to be able to use --index flag.

Commands to reproduce the bump:
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get github.com/openshift/[email protected]
go get sigs.k8s.io/[email protected]
go get sigs.k8s.io/kustomize/kustomize/[email protected]
o get sigs.k8s.io/aws-load-balancer-controller@f39ae43121c3f4de0129dda483c10b17a687491d
go get github.com/openshift/api/config/v1/[email protected]
go get sigs.k8s.io/controller-runtime/tools/setup-envtest@75a38d2123d4696d24d8d3c6b2966e7a34442653
go mod tidy
go mod vendor
make bundle
make update-vendored-crds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2024-12-17T15:51:47Z

/label px-approved

The docs are enough for this feature.

ahardin-rh · 2024-12-17T16:02:27Z

/label docs-approved

alebedev87 · 2024-12-17T22:26:12Z

Conflict on the WAF ACL resource: fix PR.

/test e2e-aws-operator

alebedev87 · 2024-12-17T23:36:07Z

/test e2e-aws-proxy-operator

ShudiLi · 2024-12-18T01:05:44Z

/label qe-approved
thanks

alebedev87 · 2024-12-18T07:34:08Z

/test e2e-aws-operator

lihongan · 2024-12-18T11:23:59Z

/lgtm

alebedev87 · 2024-12-18T12:07:07Z

/approve

openshift-ci · 2024-12-18T12:07:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [alebedev87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-12-18T22:51:55Z

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 11, 2024

openshift-ci bot requested review from candita and frobware December 11, 2024 23:39

lihongan reviewed Dec 13, 2024

View reviewed changes

alebedev87 mentioned this pull request Dec 16, 2024

NE-1808: Bump controller to v2.8.2 #139

Merged

alebedev87 force-pushed the bump-deps-for-rebase branch from 08fb760 to 1c295fa Compare December 16, 2024 15:49

alebedev87 force-pushed the bump-deps-for-rebase branch from 1c295fa to 5b6be45 Compare December 16, 2024 17:20

alebedev87 force-pushed the bump-deps-for-rebase branch from 5b6be45 to f088591 Compare December 16, 2024 17:52

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 17, 2024

alebedev87 force-pushed the bump-deps-for-rebase branch from f088591 to ab822ce Compare December 17, 2024 15:01

alebedev87 force-pushed the bump-deps-for-rebase branch from ab822ce to 56f3ebb Compare December 17, 2024 15:22

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Dec 17, 2024

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Dec 17, 2024

openshift-ci bot assigned lihongan Dec 18, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024

openshift-merge-bot bot merged commit 9181f50 into openshift:main Dec 18, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NE-1808: Bump k8s.io, openshift, controller-runtime modules and golang #143

NE-1808: Bump k8s.io, openshift, controller-runtime modules and golang #143

alebedev87 commented Dec 11, 2024 •

edited

Loading

openshift-ci-robot commented Dec 11, 2024 •

edited by openshift-ci bot

Loading

alebedev87 commented Dec 12, 2024

lihongan commented Dec 13, 2024

lihongan Dec 13, 2024

alebedev87 Dec 13, 2024

lihongan Dec 13, 2024

ShudiLi Dec 16, 2024

alebedev87 commented Dec 16, 2024

alebedev87 commented Dec 16, 2024

openshift-ci-robot commented Dec 16, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 16, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 16, 2024 •

edited by openshift-ci bot

Loading

alebedev87 commented Dec 16, 2024

alebedev87 commented Dec 16, 2024

ShudiLi commented Dec 17, 2024 •

edited

Loading

ShudiLi commented Dec 17, 2024

openshift-ci-robot commented Dec 17, 2024 •

edited by openshift-ci bot

Loading

alebedev87 commented Dec 17, 2024

alebedev87 commented Dec 17, 2024

openshift-ci-robot commented Dec 17, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 17, 2024 •

edited by openshift-ci bot

Loading

alebedev87 commented Dec 17, 2024

ahardin-rh commented Dec 17, 2024

alebedev87 commented Dec 17, 2024 •

edited

Loading

alebedev87 commented Dec 17, 2024

ShudiLi commented Dec 18, 2024

alebedev87 commented Dec 18, 2024

lihongan commented Dec 18, 2024

alebedev87 commented Dec 18, 2024

openshift-ci bot commented Dec 18, 2024

openshift-ci bot commented Dec 18, 2024

NE-1808: Bump k8s.io, openshift, controller-runtime modules and golang #143

NE-1808: Bump k8s.io, openshift, controller-runtime modules and golang #143

Conversation

alebedev87 commented Dec 11, 2024 • edited Loading

openshift-ci-robot commented Dec 11, 2024 • edited by openshift-ci bot Loading

alebedev87 commented Dec 12, 2024

lihongan commented Dec 13, 2024

lihongan Dec 13, 2024

Choose a reason for hiding this comment

alebedev87 Dec 13, 2024

Choose a reason for hiding this comment

lihongan Dec 13, 2024

Choose a reason for hiding this comment

ShudiLi Dec 16, 2024

Choose a reason for hiding this comment

alebedev87 commented Dec 16, 2024

alebedev87 commented Dec 16, 2024

openshift-ci-robot commented Dec 16, 2024 • edited by openshift-ci bot Loading

openshift-ci-robot commented Dec 16, 2024 • edited by openshift-ci bot Loading

openshift-ci-robot commented Dec 16, 2024 • edited by openshift-ci bot Loading

alebedev87 commented Dec 16, 2024

alebedev87 commented Dec 16, 2024

ShudiLi commented Dec 17, 2024 • edited Loading

ShudiLi commented Dec 17, 2024

openshift-ci-robot commented Dec 17, 2024 • edited by openshift-ci bot Loading

alebedev87 commented Dec 17, 2024

alebedev87 commented Dec 17, 2024

openshift-ci-robot commented Dec 17, 2024 • edited by openshift-ci bot Loading

openshift-ci-robot commented Dec 17, 2024 • edited by openshift-ci bot Loading

alebedev87 commented Dec 17, 2024

ahardin-rh commented Dec 17, 2024

alebedev87 commented Dec 17, 2024 • edited Loading

alebedev87 commented Dec 17, 2024

ShudiLi commented Dec 18, 2024

alebedev87 commented Dec 18, 2024

lihongan commented Dec 18, 2024

alebedev87 commented Dec 18, 2024

openshift-ci bot commented Dec 18, 2024

openshift-ci bot commented Dec 18, 2024

alebedev87 commented Dec 11, 2024 •

edited

Loading

openshift-ci-robot commented Dec 11, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 16, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 16, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 16, 2024 •

edited by openshift-ci bot

Loading

ShudiLi commented Dec 17, 2024 •

edited

Loading

openshift-ci-robot commented Dec 17, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 17, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 17, 2024 •

edited by openshift-ci bot

Loading

alebedev87 commented Dec 17, 2024 •

edited

Loading