⚠ Remove deprecated manager, webhook and cluster options #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
sbueringer
commented
Jul 25, 2023
| // Deprecated: Use Cache.Namespaces instead. | ||
| Namespace string | ||
| // Deprecated: Use Cache.SyncPeriod instead. | ||
| SyncPeriod *time.Duration |
There was a problem hiding this comment.
We forgot to deprecate this one before
k8s-ci-robot
added
the
size/L
sbueringer
force-pushed
the
pr-deprecate-opts
branch
from
a77aed2 to
e92eadb
Compare
|
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
alvaroaleman
approved these changes
Jul 25, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
damyan
added a commit
to ironcore-dev/ipam
that referenced
this pull request
Sep 5, 2023
damyan
added a commit
to ironcore-dev/ipam
that referenced
this pull request
Sep 5, 2023
* Bump sigs.k8s.io/controller-runtime from 0.15.1 to 0.16.1 Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.15.1 to 0.16.1. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.15.1...v0.16.1) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Fix metrics server bind address * Change webhook settings to match the changes from kubernetes-sigs/controller-runtime#2422 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Damyan Yordanov <[email protected]>
2 tasks
9 tasks
rriski
added a commit
to aiven/aiven-operator
that referenced
this pull request
Jan 24, 2024
- Removal of deprecated manager options: - kubernetes-sigs/controller-runtime#2422 - Context added to `EnqueueRequestsFromMapFunc` - kubernetes-sigs/controller-runtime#2139
rriski
added a commit
to aiven/aiven-operator
that referenced
this pull request
Jan 24, 2024
- Removal of deprecated manager options: - kubernetes-sigs/controller-runtime#2422 - Context added to `EnqueueRequestsFromMapFunc` - kubernetes-sigs/controller-runtime#2139
rriski
added a commit
to aiven/aiven-operator
that referenced
this pull request
Jan 24, 2024
- Removal of deprecated manager options: - kubernetes-sigs/controller-runtime#2422 - Context added to `EnqueueRequestsFromMapFunc` - kubernetes-sigs/controller-runtime#2139
rriski
added a commit
to aiven/aiven-operator
that referenced
this pull request
Jan 24, 2024
- Removal of deprecated manager options: - kubernetes-sigs/controller-runtime#2422 - Context added to `EnqueueRequestsFromMapFunc` - kubernetes-sigs/controller-runtime#2139
alebedev87
added a commit
to alebedev87/external-dns-operator
that referenced
this pull request
Aug 13, 2024
- Bump Golang to 1.22: - `CGO_ENABLED=1` is required for `go test -race` (golang/go#51235). - Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest. - Bump Controller runtime bumped to 0.18.5: - Controller's `Watch` function now has a single generic source parameter (kubernetes-sigs/controller-runtime#2783). - Manager's `CertDir` option removed, now using the dedicated webhook server option (kubernetes-sigs/controller-runtime#2422). - Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421).
alebedev87
added a commit
to alebedev87/external-dns-operator
that referenced
this pull request
Aug 13, 2024
- Bump Golang to 1.22: - Update go.mod - Update Dockerfiles - Add `CGO_ENABLED=1` to `go test -race` (golang/go#51235). - Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest. - Bump Controller runtime bumped to 0.18.5: - Controller's `Watch` function now has a single generic source parameter (kubernetes-sigs/controller-runtime#2783). - Manager's `CertDir` option removed, now using the dedicated webhook server option (kubernetes-sigs/controller-runtime#2422). - Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421).
alebedev87
added a commit
to alebedev87/external-dns-operator
that referenced
this pull request
Aug 14, 2024
- Bump Golang to 1.22: - Update go.mod - Update Dockerfiles - Add `CGO_ENABLED=1` to `go test -race` (golang/go#51235). - Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest. - Bump Controller runtime bumped to 0.18.5: - Controller's `Watch` function now has a single generic source parameter (kubernetes-sigs/controller-runtime#2783). - Manager's `CertDir` option removed, now using the dedicated webhook server option (kubernetes-sigs/controller-runtime#2422). - Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421). - Regenerate CRD and bundle manifests: - ExternalDNS API uses `metav1.LabelSelector` for the label filtering. It was updated with `+listType=atomic` marker which resulted in the addition of `x-kubernetes-list-type: atomic` to CRD.
alebedev87
added a commit
to alebedev87/external-dns-operator
that referenced
this pull request
Aug 14, 2024
- Bump Golang to 1.22: - Update go.mod - Update Dockerfiles - Add `CGO_ENABLED=1` to `go test -race` (golang/go#51235). - Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest. - Bump Controller runtime bumped to 0.18.5: - Controller's `Watch` function now has a single generic source parameter (kubernetes-sigs/controller-runtime#2783). - Manager's `CertDir` option removed, now using the dedicated webhook server option (kubernetes-sigs/controller-runtime#2422). - Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421). - Regenerate CRD and bundle manifests: - ExternalDNS API uses `metav1.LabelSelector` for the label filtering. It was updated with `+listType=atomic` marker which resulted in the addition of `x-kubernetes-list-type: atomic` to CRD.
alebedev87
added a commit
to alebedev87/external-dns-operator
that referenced
this pull request
Aug 14, 2024
- Bump Golang to 1.22: - Update go.mod - Update Dockerfiles - Add `CGO_ENABLED=1` to `go test -race` (golang/go#51235). - Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest. - Bump Controller runtime bumped to 0.18.5: - Controller's `Watch` function now has a single generic source parameter (kubernetes-sigs/controller-runtime#2783). - Manager's `CertDir` option removed, now using the dedicated webhook server option (kubernetes-sigs/controller-runtime#2422). - Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421). - Regenerate CRD and bundle manifests: - ExternalDNS API uses `metav1.LabelSelector` for the label filtering. It was updated with `+listType=atomic` marker which resulted in the addition of `x-kubernetes-list-type: atomic` to CRD. - Bump `kustomize` to v5 to fix a conflict caused by k8s.io bumps: - `kyaml` unable to use the bumped `github.com/google/gnostic-models/openapiv2` package.
alebedev87
added a commit
to alebedev87/external-dns-operator
that referenced
this pull request
Sep 3, 2024
- Bump Golang to 1.22: - Update go.mod - Update Dockerfiles - Add `CGO_ENABLED=1` to `go test -race` (golang/go#51235). - Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest. - Bump Controller runtime bumped to 0.18.5: - Controller's `Watch` function now has a single generic source parameter (kubernetes-sigs/controller-runtime#2783). - Manager's `CertDir` option removed, now using the dedicated webhook server option (kubernetes-sigs/controller-runtime#2422). - Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421). - Regenerate CRD and bundle manifests: - ExternalDNS API uses `metav1.LabelSelector` for the label filtering. It was updated with `+listType=atomic` marker which resulted in the addition of `x-kubernetes-list-type: atomic` to CRD. - Bump `kustomize` to v5 to fix a conflict caused by k8s.io bumps: - `kyaml` unable to use the bumped `github.com/google/gnostic-models/openapiv2` package.
alebedev87
added a commit
to alebedev87/external-dns-operator
that referenced
this pull request
Sep 17, 2024
- Bump Golang to 1.22: - Update go.mod - Update Dockerfiles - Add `CGO_ENABLED=1` to `go test -race` (golang/go#51235). - Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest. - Bump Controller runtime bumped to 0.18.5: - Controller's `Watch` function now has a single generic source parameter (kubernetes-sigs/controller-runtime#2783). - Manager's `CertDir` option removed, now using the dedicated webhook server option (kubernetes-sigs/controller-runtime#2422). - Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421). - Regenerate CRD and bundle manifests: - ExternalDNS API uses `metav1.LabelSelector` for the label filtering. It was updated with `+listType=atomic` marker which resulted in the addition of `x-kubernetes-list-type: atomic` to CRD. - Bump `kustomize` to v5 to fix a conflict caused by k8s.io bumps: - `kyaml` unable to use the bumped `github.com/google/gnostic-models/openapiv2` package.
alebedev87
added a commit
to alebedev87/aws-load-balancer-operator
that referenced
this pull request
Dec 11, 2024
- Bumped golang to 1.22:
- Update go.mod
- Update Dockerfiles
- Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.
- Bumped controller-runtime to 0.18.5:
- Manager's `Port` option removed, now using dedicated webhook server field (kubernetes-sigs/controller-runtime#2422).
- Manager's `MetricsBindAddress` option removed, now using dedicated metrics server field (kubernetes-sigs/controller-runtime#2407).
- Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421).
- Regenerated CRD and bundle manifests using `make bundle` command.
- Bumped `kustomize` to v5 to fix a conflict caused by k8s.io bumps:
- `kyaml` unable to use the bumped `github.com/google/gnostic-models/openapiv2` package.
alebedev87
added a commit
to alebedev87/aws-load-balancer-operator
that referenced
this pull request
Dec 11, 2024
- Bumped golang to 1.22:
- Update go.mod
- Update Dockerfiles
- Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.
- Bumped controller-runtime to 0.18.5:
- Manager's `Port` option removed, now using dedicated webhook server field (kubernetes-sigs/controller-runtime#2422).
- Manager's `MetricsBindAddress` option removed, now using dedicated metrics server field (kubernetes-sigs/controller-runtime#2407).
- Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421).
- Regenerated CRD and bundle manifests using `make bundle` command.
- Bumped `kustomize` to v5 to fix a conflict caused by k8s.io bumps:
- `kyaml` unable to use the bumped `github.com/google/gnostic-models/openapiv2` package.
- Removed `TypeMeta` from expected deployment object when it's compared to
structured one retrieved from fake client (kubernetes-sigs/controller-runtime#2633).
alebedev87
added a commit
to alebedev87/aws-load-balancer-operator
that referenced
this pull request
Dec 16, 2024
- Bumped golang to 1.22:
- Update go.mod
- Update Dockerfiles
- Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.
- Bumped controller-runtime to 0.18.5:
- Manager's `Port` option removed, now using dedicated webhook server field (kubernetes-sigs/controller-runtime#2422).
- Manager's `MetricsBindAddress` option removed, now using dedicated metrics server field (kubernetes-sigs/controller-runtime#2407).
- Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421).
- Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.
- Regenerated CRD and bundle manifests using `make bundle` command.
- Bumped `kustomize` to v5 to fix a conflict caused by k8s.io bumps:
- `kyaml` unable to use the bumped `github.com/google/gnostic-models/openapiv2` package.
- Removed `TypeMeta` from expected deployment object when it's compared to
structured one retrieved from fake client (kubernetes-sigs/controller-runtime#2633).
alebedev87
added a commit
to alebedev87/aws-load-balancer-operator
that referenced
this pull request
Dec 16, 2024
- Bumped golang to 1.22:
- Update go.mod
- Update Dockerfiles
- Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.
- Bumped controller-runtime to 0.18.5:
- Manager's `Port` option removed, now using dedicated webhook server field (kubernetes-sigs/controller-runtime#2422).
- Manager's `MetricsBindAddress` option removed, now using dedicated metrics server field (kubernetes-sigs/controller-runtime#2407).
- Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421).
- Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.
- Regenerated CRD and bundle manifests using `make bundle` command.
- Bumped `kustomize` to v5 to fix a conflict caused by k8s.io bumps:
- `kyaml` unable to use the bumped `github.com/google/gnostic-models/openapiv2` package.
- Removed `TypeMeta` from expected deployment object when it's compared to
structured one retrieved from fake client (kubernetes-sigs/controller-runtime#2633).
- Migrated infrastructure CRD retrieval to the new package `zz_generated.crd-manifests`:
- Updated infrastructure CRD for unit tests using `make update-vendored-crds` command.
alebedev87
added a commit
to alebedev87/aws-load-balancer-operator
that referenced
this pull request
Dec 16, 2024
- Bumped golang to 1.22:
- Update go.mod
- Update Dockerfiles
- Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.
- Bumped controller-runtime to 0.18.5:
- Manager's `Port` option removed, now using dedicated webhook server field (kubernetes-sigs/controller-runtime#2422).
- Manager's `MetricsBindAddress` option removed, now using dedicated metrics server field (kubernetes-sigs/controller-runtime#2407).
- Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421).
- Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.
- Regenerated CRD and bundle manifests using `make bundle` command.
- Bumped `kustomize` to v5 to fix a conflict caused by k8s.io bumps:
- `kyaml` unable to use the bumped `github.com/google/gnostic-models/openapiv2` package.
- Removed `TypeMeta` from expected deployment object when it's compared to
structured one retrieved from fake client (kubernetes-sigs/controller-runtime#2633).
- Migrated infrastructure CRD retrieval to the new package `zz_generated.crd-manifests`:
- Updated infrastructure CRD for unit tests using `make update-vendored-crds` command.
alebedev87
added a commit
to alebedev87/aws-load-balancer-operator
that referenced
this pull request
Dec 17, 2024
- Bumped golang to 1.22:
- Update go.mod
- Update Dockerfiles
- Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.
- Bumped controller-runtime to 0.18.5:
- Manager's `Port` option removed, now using dedicated webhook server field (kubernetes-sigs/controller-runtime#2422).
- Manager's `MetricsBindAddress` option removed, now using dedicated metrics server field (kubernetes-sigs/controller-runtime#2407).
- Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421).
- Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.
- Regenerated CRD and bundle manifests using `make bundle` command.
- Bumped `kustomize` to v5 to fix a conflict caused by k8s.io bumps:
- `kyaml` unable to use the bumped `github.com/google/gnostic-models/openapiv2` package.
- Removed `TypeMeta` from expected deployment object when it's compared to
structured one retrieved from fake client (kubernetes-sigs/controller-runtime#2633).
- Migrated infrastructure CRD retrieval to the new package `zz_generated.crd-manifests`:
- Updated infrastructure CRD for unit tests using `make update-vendored-crds` command.
- Updated envtest setup to use the downstream index.
- Infrastructure CRD uses CEL functions backported from newer k8s API.
- Upstream `envtest` is not ready to use newer CEL function.
- Bumped `setup-envtest` to be able to use `--index` flag.
alebedev87
added a commit
to alebedev87/aws-load-balancer-operator
that referenced
this pull request
Dec 17, 2024
- Bumped golang to 1.22:
- Update go.mod
- Update Dockerfiles
- Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf.
- Bumped controller-runtime to 0.18.5:
- Manager's `Port` option removed, now using dedicated webhook server field (kubernetes-sigs/controller-runtime#2422).
- Manager's `MetricsBindAddress` option removed, now using dedicated metrics server field (kubernetes-sigs/controller-runtime#2407).
- Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421).
- Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests.
- Regenerated CRD and bundle manifests using `make bundle` command.
- Bumped `kustomize` to v5 to fix a conflict caused by k8s.io bumps:
- `kyaml` unable to use the bumped `github.com/google/gnostic-models/openapiv2` package.
- Removed `TypeMeta` from expected deployment object when it's compared to
structured one retrieved from fake client (kubernetes-sigs/controller-runtime#2633).
- Migrated infrastructure CRD retrieval to the new package `zz_generated.crd-manifests`:
- Updated infrastructure CRD for unit tests using `make update-vendored-crds` command.
- Updated envtest setup to use the downstream index.
- Infrastructure CRD uses CEL functions backported from newer k8s API.
- Upstream `envtest` is not ready to use newer CEL function.
- Bumped `setup-envtest` to be able to use `--index` flag.
openshift-merge-bot bot
pushed a commit
to openshift/aws-load-balancer-operator
that referenced
this pull request
Dec 18, 2024
#143) - Bumped golang to 1.22: - Update go.mod - Update Dockerfiles - Bumped k8s.io/* modules to 0.30.3 and OpenShift API to 20240812094746-86145edb40cf. - Bumped controller-runtime to 0.18.5: - Manager's `Port` option removed, now using dedicated webhook server field (kubernetes-sigs/controller-runtime#2422). - Manager's `MetricsBindAddress` option removed, now using dedicated metrics server field (kubernetes-sigs/controller-runtime#2407). - Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421). - Bumped aws-load-balancer-controller to f39ae43121c3 to use latest CRD scheme in e2e tests. - Regenerated CRD and bundle manifests using `make bundle` command. - Bumped `kustomize` to v5 to fix a conflict caused by k8s.io bumps: - `kyaml` unable to use the bumped `github.com/google/gnostic-models/openapiv2` package. - Removed `TypeMeta` from expected deployment object when it's compared to structured one retrieved from fake client (kubernetes-sigs/controller-runtime#2633). - Migrated infrastructure CRD retrieval to the new package `zz_generated.crd-manifests`: - Updated infrastructure CRD for unit tests using `make update-vendored-crds` command. - Updated envtest setup to use the downstream index. - Infrastructure CRD uses CEL functions backported from newer k8s API. - Upstream `envtest` is not ready to use newer CEL function. - Bumped `setup-envtest` to be able to use `--index` flag.
This was referenced Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.