NE-1802: Bump Golang, k8s.io, OpenShift API, and controller-runtime #225

alebedev87 · 2024-08-13T14:20:13Z

Bump Golang to 1.22:
- Update go.mod
- Update Dockerfiles
- Add CGO_ENABLED=1 to go test -race (doc: document race detector cgo requirements golang/go#51235).
Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest.
Bump Controller runtime bumped to 0.18.5:
- Controller's Watch function now has a single generic source parameter
  (⚠️ Source, Event, Predicate, Handler: Add generics support kubernetes-sigs/controller-runtime#2783).
- Manager's CertDir option removed, now using the dedicated webhook server option
  (⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422).
- Cache's Namespaces option replaced by DefaultNamespaces
  (⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421).
Bump kustomize to v5 to fix a conflict caused by k8s.io bumps:
- kyaml unable to use the bumped github.com/google/gnostic-models/openapiv2 package.
Regenerate CRD and bundle manifests:
- ExternalDNS API uses metav1.LabelSelector for the label filtering.
  It was updated with +listType=atomic marker which resulted in
  the addition of x-kubernetes-list-type: atomic to CRD.

Commands to reproduce the bump:

go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get github.com/openshift/[email protected]
go get sigs.k8s.io/[email protected]
go get sigs.k8s.io/kustomize/kustomize/[email protected]
go mod tidy
go mod vendor

openshift-ci-robot · 2024-08-13T14:20:18Z

@alebedev87: This pull request references NE-1802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Bump Golang to 1.22:

CGO_ENABLED=1 is required for go test -race (doc: document race detector cgo requirements golang/go#51235).

Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest.

Bump Controller runtime bumped to 0.18.5:

Controller's Watch function now has a single generic source parameter (⚠️ Source, Event, Predicate, Handler: Add generics support kubernetes-sigs/controller-runtime#2783).

Manager's CertDir option removed, now using the dedicated webhook server option (⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422).

Cache's Namespaces option replaced by DefaultNamespaces (⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2024-08-13T16:14:10Z

golangci-lint was running out of memory (happens often when the version is out of date). Bumped golangci-lint to the latest version.
kustomize was having a conflict with the k8s.io bumps. Bumped kustomize to v5 version.

alebedev87 · 2024-08-13T16:25:50Z

Dockerfiles updated with golang 1.22.

alebedev87 · 2024-08-13T21:52:48Z

/retest

openshift-ci-robot · 2024-08-14T10:03:09Z

@alebedev87: This pull request references NE-1802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Bump Golang to 1.22:

Update go.mod

Update Dockerfiles

Add CGO_ENABLED=1 to go test -race (doc: document race detector cgo requirements golang/go#51235).

Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest.

Bump Controller runtime bumped to 0.18.5:

Controller's Watch function now has a single generic source parameter
(⚠️ Source, Event, Predicate, Handler: Add generics support kubernetes-sigs/controller-runtime#2783).

Manager's CertDir option removed, now using the dedicated webhook server option
(⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422).

Cache's Namespaces option replaced by DefaultNamespaces
(⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421).

Regenerate CRD and bundle manifests:

ExternalDNS API uses metav1.LabelSelector for the label filtering.
It was updated with +listType=atomic marker which resulted in
the addition of x-kubernetes-list-type: atomic to CRD.

Bump kustomize to v5 to fix a conflict caused by k8s.io bumps:

kyaml unable to use the bumped github.com/google/gnostic-models/openapiv2 package.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2024-08-14T10:03:41Z

Commits reorganized.

alebedev87 · 2024-08-14T11:46:23Z

/retest

Azure installation failed.

candita · 2024-08-14T15:36:57Z

/assign @gcs278
/assign

openshift-ci-robot · 2024-08-14T15:38:42Z

@alebedev87: This pull request references NE-1802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Bump Golang to 1.22:

Update go.mod

Update Dockerfiles

Add CGO_ENABLED=1 to go test -race (doc: document race detector cgo requirements golang/go#51235).

Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest.

Bump Controller runtime bumped to 0.18.5:

Controller's Watch function now has a single generic source parameter
(⚠️ Source, Event, Predicate, Handler: Add generics support kubernetes-sigs/controller-runtime#2783).

Manager's CertDir option removed, now using the dedicated webhook server option
(⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422).

Cache's Namespaces option replaced by DefaultNamespaces
(⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421).

Bump kustomize to v5 to fix a conflict caused by k8s.io bumps:

kyaml unable to use the bumped github.com/google/gnostic-models/openapiv2 package.

Regenerate CRD and bundle manifests:

ExternalDNS API uses metav1.LabelSelector for the label filtering.
It was updated with +listType=atomic marker which resulted in
the addition of x-kubernetes-list-type: atomic to CRD.

Commands to reproduce the bump:
go get k8s.io/api
go get k8s.io/client-go
go get k8s.io/apiserver
go get k8s.io/apiextensions-apiserver
go get github.com/openshift/api                                                                                        
go get sigs.k8s.io/controller-runtime
go get sigs.k8s.io/kustomize/kustomize/v5
go mod tidy
go mod vendor
Commands to test the bump:
make bundle build test verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

candita · 2024-08-15T14:06:54Z

.ci-operator.yaml

@@ -1,4 +1,4 @@
 build_root_image:
  name: release
  namespace: openshift
-  tag: rhel-8-release-golang-1.19-openshift-4.12
+  tag: rhel-8-release-golang-1.22-openshift-4.17


Should you be using rhel-9 in the name instead of rhel-8 ?

I thought of postponing the migration to RHEL9 to not put all the eggs into one basket (rebase from upstream is huge plus this bump turned into a big one). Let's see if we'll have enough time to do RHEL9 migration too. But anyway it will be in a dedicated PR.

candita · 2024-08-15T14:13:45Z

/retest

gcs278 · 2024-08-15T23:28:17Z

@alebedev87, a nit pick, but your commands:

go get k8s.io/api
go get k8s.io/client-go
go get k8s.io/apiserver
go get k8s.io/apiextensions-apiserver
go get github.com/openshift/api                                                                                        
go get sigs.k8s.io/controller-runtime
go get sigs.k8s.io/kustomize/kustomize/v5
go mod tidy
go mod vendor

Doesn't produce the same versions that you have bumped to. I get v0.31.0 K8S packages now, logr v1.4.1, and I also get this error:

go: github.com/openshift/external-dns-operator/tools imports
	sigs.k8s.io/kustomize/kustomize/v4 imports
	sigs.k8s.io/kustomize/kustomize/v4/commands imports
	sigs.k8s.io/kustomize/kustomize/v4/commands/create imports
	sigs.k8s.io/kustomize/api/loader: module sigs.k8s.io/kustomize/api@latest found (v0.17.3), but does not contain package sigs.k8s.io/kustomize/api/loader

Sorry, I am one of those people that like to reproduce the bump as a sanity check 😄 I think you need to pin your versions.

gcs278

No major issue, just questions.

gcs278 · 2024-08-15T22:14:38Z

.ci-operator.yaml

Sorry if I have missed a conversation about this, but doesn't splitting the bump & the vendor into two separate commits make the bump commit "broken"?

It could be just my personal philosophy, but I thought best practice was to avoid creating commits that don't compile. Was the motivation just to make reviews easier? I'm open to differing opinions, feel free to disagree, just curious.

Reminded me of this discussion we had in C-I-O. I think I keep trying to stick to what I said in the discussion: put the vendor dir into a dedicated commit if either is true:

it's more convenient for the reviewer

the PR will be backported (vendored files may cause a lot of cherry-pick conflicts)

Was the motivation just to make reviews easier?

Yes. Will rebase the PR (fixup the vendor commit) once ready to move on.

There might be a small miscommunication, in the CIO discussion, I was referring to splitting out the vendor & bump commit as one together. I referred to that as the "vendor commit" there.

But in this PR, we have a "bump commit" and "vendor dir commit" separate. By bump commit, I mean the go get ... && go mod tidy commands (b871828). By "vendor dir commit", I mean go mod vendor (67ec0f2).

Will rebase the PR (fixup the vendor commit) once ready to move on.

What does that mean exactly? Are you saying your going to combine your b871828 67ec0f2 commits before merging?

There might be a small miscommunication, in the openshift/cluster-ingress-operator#1097 (comment), I was referring to splitting out the vendor & bump commit as one together. I referred to that as the "vendor commit" there.

But in this PR, we have a "bump commit" and "vendor dir commit" separate. By bump commit, I mean the go get ... && go mod tidy commands (b871828). By "vendor dir commit", I mean go mod vendor (67ec0f2).

Got it now. Yes, I understood the vendor commit as a commit with vendor dir only.

Will rebase the PR (fixup the vendor commit) once ready to move on.

What does that mean exactly? Are you saying your going to combine your b871828 67ec0f2 commits before merging?

Yes, will leave the PR will 2 commits: "bump+vendor dir" and "golangci-lint commit".

Okay I think we are on the same page now. Thanks!

gcs278 · 2024-08-15T22:56:01Z

Dockerfile.openshift

 WORKDIR /external-dns-operator
 COPY . .
 RUN make build-operator

-FROM registry.ci.openshift.org/ocp/4.12:base
+FROM registry.ci.openshift.org/ocp/4.17:base


Can you remind me how this works? I think we still substitute all of the base image no per the release repo?

Regardless, I think at one point we discussed trying to get this hooked up with the Art bot so it stays in sync. I think this won't be very sustainable to keep updating.

As of now external-dns-operator repo controls the base, builder and build root images from the repository. So when we need to bump golang or base image we submit a PR only into this repo. That means less automation from ART indeed. But we disabled it to get rid of openshift release branches created automatically. That was causing a confusion about the adherence of ExternalDNS Operator to OCP lifecycle.

As a matter of fact, Dockerfile.openshift is not even used anymore. I updated Dockerfile.openshift just to be consistent but it can be removed.

As a matter of fact, Dockerfile.openshift is not even used anymore. I updated Dockerfile.openshift just to be consistent but it can be removed.

Oh, so this Dockerfile isn't even used? That makes more sense why this is super outdated. Now I see the regular Dockerfile uses it's own non-OpenShift images, which makes my question about the ART bumps irrelevant.

Should we just delete it then or does it serve a purpose still?

Should we just delete it then or does it serve a purpose still?

No it doesn't. Let me remove it.

Upd: done.

openshift-ci-robot · 2024-08-16T10:31:31Z

@alebedev87: This pull request references NE-1802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Bump Golang to 1.22:

Update go.mod

Update Dockerfiles

Add CGO_ENABLED=1 to go test -race (doc: document race detector cgo requirements golang/go#51235).

Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest.

Bump Controller runtime bumped to 0.18.5:

Controller's Watch function now has a single generic source parameter
(⚠️ Source, Event, Predicate, Handler: Add generics support kubernetes-sigs/controller-runtime#2783).

Manager's CertDir option removed, now using the dedicated webhook server option
(⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422).

Cache's Namespaces option replaced by DefaultNamespaces
(⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421).

Bump kustomize to v5 to fix a conflict caused by k8s.io bumps:

kyaml unable to use the bumped github.com/google/gnostic-models/openapiv2 package.

Regenerate CRD and bundle manifests:

ExternalDNS API uses metav1.LabelSelector for the label filtering.
It was updated with +listType=atomic marker which resulted in
the addition of x-kubernetes-list-type: atomic to CRD.

Commands to reproduce the bump:
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get github.com/openshift/[email protected]
go get sigs.k8s.io/[email protected]
go get sigs.k8s.io/kustomize/kustomize/[email protected]
go mod tidy
go mod vendor
Commands to test the bump:
make bundle build test verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-08-16T10:31:51Z

@alebedev87: This pull request references NE-1802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Bump Golang to 1.22:

Update go.mod

Update Dockerfiles

Add CGO_ENABLED=1 to go test -race (doc: document race detector cgo requirements golang/go#51235).

Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest.

Bump Controller runtime bumped to 0.18.5:

Controller's Watch function now has a single generic source parameter
(⚠️ Source, Event, Predicate, Handler: Add generics support kubernetes-sigs/controller-runtime#2783).

Manager's CertDir option removed, now using the dedicated webhook server option
(⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422).

Cache's Namespaces option replaced by DefaultNamespaces
(⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421).

Bump kustomize to v5 to fix a conflict caused by k8s.io bumps:

kyaml unable to use the bumped github.com/google/gnostic-models/openapiv2 package.

Regenerate CRD and bundle manifests:

ExternalDNS API uses metav1.LabelSelector for the label filtering.
It was updated with +listType=atomic marker which resulted in
the addition of x-kubernetes-list-type: atomic to CRD.

Commands to reproduce the bump:
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get github.com/openshift/[email protected]
go get sigs.k8s.io/[email protected]
go get sigs.k8s.io/kustomize/kustomize/[email protected]
go mod tidy
go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2024-08-16T10:33:14Z

@gcs278 : Pinned the go get commands to exact versions. Indeed, 1.31 Kube was released at the same time as I posted the PR.

candita · 2024-08-20T18:31:10Z

e2e TestExternalDNSRecordLifecycle is failing. Let's see if that is intermittent?
/test e2e-gcp-operator

operator_test.go:212: Ensuring test namespace
operator_test.go:218: Creating credentials secret
operator_test.go:225: Creating external dns instance
operator_test.go:235: Creating source service
common.go:279: Getting IPs of service's load balancer
(repeats)
common.go:279: Getting IPs of service's load balancer
operator_test.go:247: failed to get service IPs external-dns-test/test-service: failed to get loadbalancer IPs for service test-service/external-dns-test: client rate limiter Wait returned an error: context deadline exceeded

--- FAIL: TestExternalDNSRecordLifecycle (180.33s)

candita · 2024-08-20T18:39:17Z

Makefile

@@ -211,7 +211,7 @@ endef
 .PHONY: lint
 ## Checks the code with golangci-lint
 lint: $(GOLANGCI_LINT_BIN)
-	$(GOLANGCI_LINT_BIN) run -c .golangci.yaml --deadline=30m


Question - is there another way to give this a time limit, now that the deadline flag is deprecated?

Yes. It's already in the golangci-lint config. I don't see the reason to limit in 2 places, so I removed the flag completely. Also, 30m was an overkill, this test should not take more than a couple of seconds.

Upd: maybe a "couple of seconds" was a wrong estimation (failed job). Increased to 10 minutes.

candita · 2024-08-20T18:58:16Z

Makefile

-KUSTOMIZE := go run sigs.k8s.io/kustomize/kustomize/v4
-K8S_ENVTEST_VERSION := 1.21.4
+KUSTOMIZE := go run sigs.k8s.io/kustomize/kustomize/v5
+K8S_ENVTEST_VERSION := 1.30.0


Any reason to use 1.30.0 instead of 1.30.3 as is used in the go modules?

Yes. sigs.k8s.io/controller-runtime/tools/setup-envtest gets the artifacts from kubebuilder-tools which used to be published from the kubebuilder repository. Here is the link to all the kubebuilder tools releases available which I found in their latest release. There is no 1.30.3 release, that why I'm getting an error when I'm trying to use 1.30.3:

$ make test go run sigs.k8s.io/controller-tools/cmd/controller-gen "crd:preserveUnknownFields=false" rbac:roleName=external-dns-operator webhook paths="./..." output:crd:artifacts:config=config/crd/bases go run sigs.k8s.io/controller-tools/cmd/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..." go fmt ./... go vet ./... unable to fetch hash for requested version: unable fetch metadata for kubebuilder-tools-1.30.3-linux-amd64.tar.gz -- got status "404 Not Found" from GCS

I think that we'll have to upgrade to the latest version of sigs.k8s.io/controller-runtime/tools/setup-envtest and start fetching the envtest binaries from the new location. The problem is that we cannot do it right now as the latest version uses 1.31.z k8s.io dependencies. So we have to postpone it to the next API bump.

candita · 2024-08-20T19:11:01Z

pkg/operator/controller/ca-configmap/controller.go

+		source.Kind[client.Object](operatorCache, &corev1.ConfigMap{},
+			&handler.EnqueueRequestForObject{},
+			predicate.And(predicate.NewPredicateFuncs(ctrlutils.InNamespace(config.SourceNamespace)), predicate.NewPredicateFuncs(ctrlutils.HasName(config.CAConfigMapName))),


nit: was this manual or automatic? If source.Kind changed this much, it might be better to put all the signature parameters on the same line.

was this manual or automatic?

Manual, I had to do it myself. As far as I know, no migration tools were provided by controller-runtime.

If source.Kind changed this much, it might be better to put all the signature parameters on the same line.

Yes, source.Kind is a generic function now. Wouldn't it be too lengthy on a single line?

gcs278 · 2024-08-20T22:26:25Z

go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get github.com/openshift/[email protected]
go get sigs.k8s.io/[email protected]
go get sigs.k8s.io/kustomize/kustomize/[email protected]

The failure here is probably due to a too small DnsPollingTimeout. 3 Minutes isn't enough to provision the LB, much less resolve the DNS name. I saw in Loki that the GCP CCM took 5 minutes to provision the LB. That's quite long, probably an anomaly with the GCP API being slow. It's a flake to keep an eye on.

alebedev87 · 2024-08-28T13:49:57Z

@gcs278 : 3 minutes may be too short indeed. Some time ago, I decreased it from 15 minutes to reduce the elapsed time needed for a failed run. I'll try to do the happy medium and will increase it to 7 minutes.

alebedev87 · 2024-08-28T14:32:28Z

Increased the golangci-lint timeout to 10m.

alebedev87 · 2024-09-12T09:08:58Z

/label px-approved

No TE is needed for this feature, only release notes.

jmanthei · 2024-09-13T14:35:44Z

/label docs-approved

jmanthei · 2024-09-13T14:36:45Z

/label px-approved

No TE is needed for this feature, only release notes.

No release note for this specific change as we do not make release notes for bumping kubernetes dependencies.

openshift-ci-robot · 2024-09-13T17:50:10Z

/retest-required

Remaining retests: 0 against base HEAD b2a62fe and 2 for PR HEAD e506cf5 in total

alebedev87 · 2024-09-15T07:42:46Z

All Azure tests failed to get DNS records, not much can be found in Loki. Let's see whether it's a reproducible issue.

/retest

openshift-ci-robot · 2024-09-16T09:21:04Z

/retest-required

Remaining retests: 0 against base HEAD b2a62fe and 2 for PR HEAD e506cf5 in total

openshift-ci-robot · 2024-09-16T12:54:02Z

/retest-required

Remaining retests: 0 against base HEAD b2a62fe and 2 for PR HEAD e506cf5 in total

openshift-ci-robot · 2024-09-16T15:25:23Z

/retest-required

Remaining retests: 0 against base HEAD b2a62fe and 2 for PR HEAD e506cf5 in total

openshift-ci-robot · 2024-09-16T17:34:40Z

/retest-required

Remaining retests: 0 against base HEAD b2a62fe and 2 for PR HEAD e506cf5 in total

openshift-ci-robot · 2024-09-17T03:53:39Z

/retest-required

Remaining retests: 0 against base HEAD b2a62fe and 2 for PR HEAD e506cf5 in total

openshift-ci-robot · 2024-09-17T08:44:58Z

/retest-required

Remaining retests: 0 against base HEAD b2a62fe and 2 for PR HEAD e506cf5 in total

openshift-ci-robot · 2024-09-17T12:01:46Z

/retest-required

Remaining retests: 0 against base HEAD b2a62fe and 2 for PR HEAD e506cf5 in total

- Bump Golang to 1.22: - Update go.mod - Update Dockerfiles - Add `CGO_ENABLED=1` to `go test -race` (golang/go#51235). - Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest. - Bump Controller runtime bumped to 0.18.5: - Controller's `Watch` function now has a single generic source parameter (kubernetes-sigs/controller-runtime#2783). - Manager's `CertDir` option removed, now using the dedicated webhook server option (kubernetes-sigs/controller-runtime#2422). - Cache's `Namespaces` option replaced by `DefaultNamespaces` (kubernetes-sigs/controller-runtime#2421). - Regenerate CRD and bundle manifests: - ExternalDNS API uses `metav1.LabelSelector` for the label filtering. It was updated with `+listType=atomic` marker which resulted in the addition of `x-kubernetes-list-type: atomic` to CRD. - Bump `kustomize` to v5 to fix a conflict caused by k8s.io bumps: - `kyaml` unable to use the bumped `github.com/google/gnostic-models/openapiv2` package.

- Update deprecated fields in `.golangci.yaml`. - Remove deprecated `--deadline` flag. - Replace deprecated `k8s.io/utils/pointer` with new generic `k8s.io/utils/ptr` package.

CI and Makefile use default Dockerfile.

Increase the DNS polling timeout to 7 minutes to prevent false positives on providers with slower load balancer provisioning, such as GCP, where it may take up to 5 minutes.

openshift-ci-robot · 2024-09-17T15:01:33Z

/retest-required

Remaining retests: 0 against base HEAD b2a62fe and 2 for PR HEAD e506cf5 in total

The RHEL9 migration (openshift/external-dns#61) reset the latest tag for external-dns repository in quay.io.

alebedev87 · 2024-09-17T15:07:48Z

The problems seen in Azure were related to removed operand image. The external-dns instances could not start. I blame the changes in the image mirroring in release repository (initial script was preserving all unique images) as well as my unsolicited tag I used for the tests (unlikely though).

Anyway the operand was migrated to RHEL9 so I rebump the operand image.

gcs278 · 2024-09-17T19:32:28Z

/lgtm

openshift-ci-robot · 2024-09-17T20:15:28Z

/retest-required

Remaining retests: 0 against base HEAD b2a62fe and 2 for PR HEAD f1b2155 in total

openshift-ci · 2024-09-17T21:30:26Z

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 13, 2024

openshift-ci bot requested review from gcs278 and Miciah August 13, 2024 14:21

alebedev87 force-pushed the bump-n-rebase branch from db88266 to 3f92d3b Compare August 13, 2024 16:25

alebedev87 force-pushed the bump-n-rebase branch from 3f92d3b to e9c00b9 Compare August 14, 2024 10:00

openshift-ci bot assigned candita and gcs278 Aug 14, 2024

candita reviewed Aug 15, 2024

View reviewed changes

gcs278 reviewed Aug 15, 2024

View reviewed changes

candita reviewed Aug 20, 2024

View reviewed changes

alebedev87 force-pushed the bump-n-rebase branch from 7ab2709 to 34958da Compare August 28, 2024 14:31

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Sep 12, 2024

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Sep 13, 2024

alebedev87 added 4 commits September 17, 2024 15:49

golangci-lint: Bump to latest to fix high memory consumption

fbf0a43

- Update deprecated fields in `.golangci.yaml`. - Remove deprecated `--deadline` flag. - Replace deprecated `k8s.io/utils/pointer` with new generic `k8s.io/utils/ptr` package.

Remove unused Dockerfile.openshift

c544748

CI and Makefile use default Dockerfile.

e2e: increase DNS polling timeout to 7 minutes

d11060f

Increase the DNS polling timeout to 7 minutes to prevent false positives on providers with slower load balancer provisioning, such as GCP, where it may take up to 5 minutes.

manifests: bump operator image to latest(42c9f6d6b01d)

f1b2155

The RHEL9 migration (openshift/external-dns#61) reset the latest tag for external-dns repository in quay.io.

alebedev87 force-pushed the bump-n-rebase branch from e506cf5 to f1b2155 Compare September 17, 2024 15:06

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024

openshift-merge-bot bot merged commit 63fb086 into openshift:main Sep 17, 2024
10 checks passed

alebedev87 mentioned this pull request Sep 18, 2024

OCPBUGS-41683: Use RHEL9 as baseimage and build root image #227

Merged

NE-1802: Bump Golang, k8s.io, OpenShift API, and controller-runtime #225

NE-1802: Bump Golang, k8s.io, OpenShift API, and controller-runtime #225

Conversation

alebedev87 commented Aug 13, 2024 • edited Loading

openshift-ci-robot commented Aug 13, 2024 • edited by openshift-ci bot Loading

alebedev87 commented Aug 13, 2024

alebedev87 commented Aug 13, 2024

alebedev87 commented Aug 13, 2024

openshift-ci-robot commented Aug 14, 2024 • edited by openshift-ci bot Loading

alebedev87 commented Aug 14, 2024

alebedev87 commented Aug 14, 2024

candita commented Aug 14, 2024

openshift-ci-robot commented Aug 14, 2024 • edited by openshift-ci bot Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

candita commented Aug 15, 2024

gcs278 commented Aug 15, 2024

gcs278 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alebedev87 Aug 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alebedev87 Aug 16, 2024 • edited Loading

Choose a reason for hiding this comment

openshift-ci-robot commented Aug 16, 2024 • edited by openshift-ci bot Loading

openshift-ci-robot commented Aug 16, 2024 • edited by openshift-ci bot Loading

alebedev87 commented Aug 16, 2024 • edited Loading

candita commented Aug 20, 2024 • edited Loading

Choose a reason for hiding this comment

alebedev87 Aug 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alebedev87 Aug 28, 2024 • edited Loading

Choose a reason for hiding this comment

gcs278 commented Aug 20, 2024

alebedev87 commented Aug 28, 2024

alebedev87 commented Aug 28, 2024

alebedev87 commented Sep 12, 2024

jmanthei commented Sep 13, 2024

jmanthei commented Sep 13, 2024

openshift-ci-robot commented Sep 13, 2024

alebedev87 commented Sep 15, 2024

openshift-ci-robot commented Sep 16, 2024

openshift-ci-robot commented Sep 16, 2024

openshift-ci-robot commented Sep 16, 2024

openshift-ci-robot commented Sep 16, 2024

openshift-ci-robot commented Sep 17, 2024

openshift-ci-robot commented Sep 17, 2024

openshift-ci-robot commented Sep 17, 2024

openshift-ci-robot commented Sep 17, 2024

alebedev87 commented Sep 17, 2024 • edited Loading

gcs278 commented Sep 17, 2024

openshift-ci-robot commented Sep 17, 2024

openshift-ci bot commented Sep 17, 2024

alebedev87 commented Aug 13, 2024 •

edited

Loading

openshift-ci-robot commented Aug 13, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 14, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 14, 2024 •

edited by openshift-ci bot

Loading

alebedev87 Aug 16, 2024 •

edited

Loading

alebedev87 Aug 16, 2024 •

edited

Loading

openshift-ci-robot commented Aug 16, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 16, 2024 •

edited by openshift-ci bot

Loading

alebedev87 commented Aug 16, 2024 •

edited

Loading

candita commented Aug 20, 2024 •

edited

Loading

alebedev87 Aug 28, 2024 •

edited

Loading

alebedev87 Aug 28, 2024 •

edited

Loading

alebedev87 commented Sep 17, 2024 •

edited

Loading