-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: e2e: Add unix timestamp to WAF ACL names to avoid conflicts #145
NO-JIRA: e2e: Add unix timestamp to WAF ACL names to avoid conflicts #145
Conversation
WAF ACL may be create by one CI job but removed by another which may result into failed e2e test cases. This commit adds Unix timestamp to WAF ACL names to minimize the occurrence of such situations.
@alebedev87: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label docs-approved Just a technical change in e2e tests. |
/approve I don't think I can but let's try. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label qe-approved |
/lgtm |
/override ci/prow/e2e-aws-proxy-operator The blackhole networking deprovision failed, not related to the change or anything we do. |
@alebedev87: Overrode contexts on behalf of alebedev87: ci/prow/e2e-aws-proxy-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
WAF ACL may be create by one CI job but removed by another which may result into failed e2e test cases.
This commit adds Unix timestamp to WAF ACL names to minimize the occurrence of such situations.