Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport v1alpha1 hacks #160

Merged
merged 3 commits into from
Apr 22, 2021
Merged

Backport v1alpha1 hacks #160

merged 3 commits into from
Apr 22, 2021

Conversation

slinkydeveloper
Copy link

No description provided.

@slinkydeveloper
Upgraded storage version of kafkachannel (knative-extensions#446)
9460e98 
* Upgraded storage version of kafkachannel

Signed-off-by: Francesco Guardiani <[email protected]>

* Fix tests

Signed-off-by: Francesco Guardiani <[email protected]>
@slinkydeveloper
Added post-install script to migrate KafkaChannel to v1beta1 (knative…
772bb78 
…-extensions#448)

* Added post-install script to migrate KafkaChannel to v1beta1

Signed-off-by: Francesco Guardiani <[email protected]>

* ./hack/update-codegen.sh

Signed-off-by: Francesco Guardiani <[email protected]>

* Fixed labels

Signed-off-by: Francesco Guardiani <[email protected]>

* Fix labels stuff

Signed-off-by: Francesco Guardiani <[email protected]>

* Reverted also tests stuff

Signed-off-by: Francesco Guardiani <[email protected]>
@slinkydeveloper
Tap subscriptions too when running the post nstal (knative-extensions…
fb027c6 
…#473)

Signed-off-by: Francesco Guardiani <[email protected]>
@matzew
Copy link
Member

matzew commented Apr 19, 2021

Let's link tp the upstream PR for this
/hold

@matzew
Copy link
Member

matzew commented Apr 19, 2021

This depends on openshift/knative-eventing#1213
should we see and update the golang bits of the (vendored) eventing repo too ? (e.g. or update them so we have the changes vendored?)

@slinkydeveloper
Copy link
Author

should we see and update the golang bits of the (vendored) eventing repo too ? (e.g. or update them so we have the changes vendored?)

It shouldn't make any difference, since the subscription webhook affected by that PR is built in the eventing repo

matzew
matzew approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/unhold

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [matzew,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2c1595b into openshift-knative:release-v0.21.0 Apr 22, 2021
@slinkydeveloper slinkydeveloper deleted the backport_v1alpha1_hacks branch April 22, 2021 08:45
@matzew matzew mentioned this pull request May 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@lberk lberk Awaiting requested review from lberk

Assignees

@matzew matzew

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slinkydeveloper @matzew @openshift-ci-robot @openshift-merge-robot