Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Post install script, part 2 #473

Conversation

slinkydeveloper
Copy link
Contributor

Followup of #448, for more details check out #426

@slinkydeveloper slinkydeveloper requested review from a team as code owners March 18, 2021 10:57
@slinkydeveloper slinkydeveloper requested review from a team March 18, 2021 10:57
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 18, 2021
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2021
@slinkydeveloper slinkydeveloper changed the title Post install script Post install script, part 2 Mar 18, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 18, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #473 (3483a5f) into main (59b7a9b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #473   +/-   ##
=======================================
  Coverage   73.80%   73.80%           
=======================================
  Files         138      138           
  Lines        5325     5325           
=======================================
  Hits         3930     3930           
  Misses       1148     1148           
  Partials      247      247           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b7a9b...3483a5f. Read the comment docs.

@matzew
Copy link
Contributor

matzew commented Mar 18, 2021

/retest

@matzew
Copy link
Contributor

matzew commented Mar 18, 2021

related: knative/eventing#5085

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2021
@knative-prow-robot knative-prow-robot merged commit 63d04bd into knative-extensions:main Mar 18, 2021
@slinkydeveloper slinkydeveloper deleted the post_install_script branch April 19, 2021 13:57
slinkydeveloper added a commit to slinkydeveloper/eventing-kafka that referenced this pull request Apr 19, 2021
slinkydeveloper added a commit to slinkydeveloper/eventing-kafka that referenced this pull request Apr 19, 2021
openshift-merge-robot referenced this pull request in openshift-knative/eventing-kafka Apr 22, 2021
* Upgraded storage version of kafkachannel (#446)

* Upgraded storage version of kafkachannel

Signed-off-by: Francesco Guardiani <[email protected]>

* Fix tests

Signed-off-by: Francesco Guardiani <[email protected]>

* Added post-install script to migrate KafkaChannel to v1beta1 (#448)

* Added post-install script to migrate KafkaChannel to v1beta1

Signed-off-by: Francesco Guardiani <[email protected]>

* ./hack/update-codegen.sh

Signed-off-by: Francesco Guardiani <[email protected]>

* Fixed labels

Signed-off-by: Francesco Guardiani <[email protected]>

* Fix labels stuff

Signed-off-by: Francesco Guardiani <[email protected]>

* Reverted also tests stuff

Signed-off-by: Francesco Guardiani <[email protected]>

* Tap subscriptions too when running the post nstal (#473)

Signed-off-by: Francesco Guardiani <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants